4 Commits

Author SHA1 Message Date
Jeremy Stanley
0d066f954d Remove unsigned tagging permission from projects
Now that we have a fix in place for Gerrit's tag signature detection
regression, remove the unsafe permission for pushing unsigned tags
to return everything to the state we had prior to the 3.4 upgrade.

Change-Id: Ia9afb5fb4be311cca59d3e1cf3b7bc611184fe15
2022-01-25 17:41:19 +00:00
Jeremy Stanley
83ca7a97f9 Work around signed tag regression from Gerrit 3.4
Upon upgrading from Gerrit 3.3 to 3.4, a regression was observed in
which jgit no longer returns signatures in its tag messages, causing
Gerrit to misidentify signed tags as unsigned (annotated) tags.
Because our ACLs only allow signed tags to be pushed, this
regression prevents Gerrit from accepting them now.

Temporarily grant permission to push unsigned tags to anyone who
has permission to push signed ones. We will revert that as soon as a
fixed Gerrit is in place, but in the meantime users will be warned
to take care when pushing tags so that they don't accidentally push
actually unsigned tags to Gerrit.

Also, the pushSignedTag keyword was deprecated in favor of the new
createSignedTag name, so go ahead and update to that while we're
doing this so that we can limit the amount of churn across all these
ACLs. Documentation will be corrected to recommend the new format in
a separate change, but update the ACL linter now to prevent the old
syntax from being used in new projects.

This workaround was already tested on opendev/bindep in the parent
Iad8c1f83e247c9a8bcf5b4f530f7b83663e1f793 change, and confirmed to
function as intended.

Change-Id: Ia426ea36b4e6877fdce5725ff1e00ae02c62e3f4
2022-01-25 17:40:31 +00:00
Monty Taylor
5038a9191f Be clear that zone repos are owned by infra-core
Until we have a better triggering story, this is purely an
infra-core repo.

Change-Id: I6eee810b524a45eb03901ca3d1add911182114c0
2020-04-02 15:56:23 -05:00
Monty Taylor
a9842682bc Rename opendev projects we missed
In the next batch of renames, we should clean up after the
repos we missed the first time.

Depends-On: https://review.opendev.org/657275
Change-Id: I4a70949c5d90970d29608f5a70c8af8d3ed85b17
2019-05-29 15:01:55 -07:00