fix a "bug" in that the flake8 configuration in tox.ini was exclusively
selecting H231 as the only error it would report, so it was missing the
errors in the python modules (such as submit_log_processor_jobs). Due to
this being the case for a long time (since 2004) limit the more thorough
linting to the roles/ and playbooks/ directories where we'll be adding
ansible plugins/modules/etc. Also, lint in jenkins/script and nodepool.
Fix problems found.
We can lint everything with pep8 once the zuul v2 scripts are removed,
not worth patching them right now.
Change-Id: I479f010643cf3b67c183d763510f07a33400d38b
Co-Authored-By: Jesse Keating <omgjlk@us.ibm.com>
The repos checkout needs to be in the PYTHONPATH for the
import of the xstatic module to work. Since we invoke
the xstatic_check_version.py by absolute path, Python
does not include the cwd() in the PYTHONPATH.
Change-Id: Idd4f8db6334c9f29168e3bc39de3ed95a4e1c60f
For testing the proposed version checking job
it is being added to the experimental queue.
This check will be run in the release job as a pre-check
to ensure that the tag triggering the release matches
the version encoded in the release's files. If the version
coded in the tag doesn't match the version in the xstatic
package, it must be rejected.
Co-Authored-By: Joshua Hesketh <josh@nitrotech.org>
Change-Id: I04765ccc8c3a72758391ab147e7d5d79b828fd21