6 Commits

Author SHA1 Message Date
Steve Kowalik
85a0f4f44f Switch to using $() for subshells, part 1
Cleanup every use of `` for subshells in the nodepool and tools
directory , replacing them with $(), and finally making the scripts
consistent.

Change-Id: I2b05cd20f9c9a30ab88f8db235aa81da93b1fad3
2015-06-04 15:30:55 +10:00
Doug Hellmann
561ac5dc82 Add detail to gerrit ACL normalization errors
When the ACL file normalization checker failed it only mentioned the
filename, with the actual error output from diff potentially many many
lines up in the scrollback. This change saves the diff output so it can
be reported at the end of the run where the failure happens.

Change-Id: I862f755c6ed96208c0fe8255175afb48847f8cad
2015-03-10 20:00:28 +00:00
armando-migliaccio
a3034dfcbe Add openstack-infra to the list of namespaces to check.
Change-Id: I8ff59dccc06df7ab23d13eca6990418f3a547d34
2014-12-19 11:44:03 -08:00
armando-migliaccio
af09d7ca4b Extend ACL checks to OpenStack namespace.
Change-Id: I0ac6ee99391f218fa467b58bf39934c6c68d1808
2014-12-17 14:03:31 -08:00
Andreas Jaeger
d8416301e8 Check that Gerrit ACL files are normalized
Enhance Gerrit ACL check to check that the files are properly
normalized.

Co-Authored-By: Armando Migliaccio <armamig@gmail.com>

Change-Id: I9cdee60e77dab9c6943626d5fa1eda0402840277
2014-12-15 23:04:12 -08:00
armando-migliaccio
e6573ea752 Add test for validating certain gerrit ACL rules
This patch adds a check for Gerrit ACL configs. In this initial
version, the test being added checks that the config defines
at least one team that acts as a core/admin one.

The current check is intentially pretty loose to ensure some
flexibility.

Currently the check applies to stackforge and openstack-dev only.

Change-Id: I2b04f2d94130699d6fd1c16a9b00b9c81d1ba07d
2014-12-15 23:03:03 -08:00