Cleanup every use of `` for subshells in the nodepool and tools
directory , replacing them with $(), and finally making the scripts
consistent.
Change-Id: I2b05cd20f9c9a30ab88f8db235aa81da93b1fad3
When the ACL file normalization checker failed it only mentioned the
filename, with the actual error output from diff potentially many many
lines up in the scrollback. This change saves the diff output so it can
be reported at the end of the run where the failure happens.
Change-Id: I862f755c6ed96208c0fe8255175afb48847f8cad
Enhance Gerrit ACL check to check that the files are properly
normalized.
Co-Authored-By: Armando Migliaccio <armamig@gmail.com>
Change-Id: I9cdee60e77dab9c6943626d5fa1eda0402840277
This patch adds a check for Gerrit ACL configs. In this initial
version, the test being added checks that the config defines
at least one team that acts as a core/admin one.
The current check is intentially pretty loose to ensure some
flexibility.
Currently the check applies to stackforge and openstack-dev only.
Change-Id: I2b04f2d94130699d6fd1c16a9b00b9c81d1ba07d