libyaml now needs to Loader keyword to not throw a warning, use
safe_load instead everywhere.
sort_keys isn't supported for reasons surpassing understanding, so
switch to ruamel.yaml for the places where we write contents back
out.
Our ruamel.yaml wrapper strips extra leading space, which is needed
when the root object is a list. When the root object is NOT a list,
it's not needed. Add a flag to the constructor to toggle the
behavior.
For gerrit/projects.yaml this leads to a different wrapping of
description fields, which is included here.
Let ruamel.yaml handle comments
Since we've switched to ruamel.yaml, we don't need to strip
comments. Stop stripping them. Intra-list comments aren't
supported, so just remove them.
Please don't ask me why we can't have a space before openstack-merlin.
Change-Id: I72776774eabd4e397ee5e8bdd58b3632be8fd3a1
This event is currently a noop and a new event name is in the works to
replace its intended functionality. This removes all references to the
non-functional notification. Teams can add the new replacement
notification once it's available if they want to have these.
Change-Id: Iad5fd75bc10924b483a14a449853b6b8e7c4c465
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
fix a "bug" in that the flake8 configuration in tox.ini was exclusively
selecting H231 as the only error it would report, so it was missing the
errors in the python modules (such as submit_log_processor_jobs). Due to
this being the case for a long time (since 2004) limit the more thorough
linting to the roles/ and playbooks/ directories where we'll be adding
ansible plugins/modules/etc. Also, lint in jenkins/script and nodepool.
Fix problems found.
We can lint everything with pep8 once the zuul v2 scripts are removed,
not worth patching them right now.
Change-Id: I479f010643cf3b67c183d763510f07a33400d38b
Co-Authored-By: Jesse Keating <omgjlk@us.ibm.com>
gerritbot can now handle more than 120 channels, remove the test for it.
Change-Id: If6d1630581762aab93c979ba7852f845bc2846f5
Depends-On: Ifafeed77e640bc7b5910251c619358a8a2bd78a6
Capitalize ERROR for all project-config specific tests, so
that errors can found easily.
Add missing ERROR marks.
Change-Id: I1d7e1077de62945647e0329462016a34eaabd83e
Recently a change merged that had not branches line and gerritbot
refused to start again. This could have been avoided by validation of
the file.
Test some basic validation of the yaml file to avoid breakage.
Change-Id: I2dc4a28aeac07d3fc73d3954d8fbe8f2448334e5
The scripts was always returning 0 - see
https://review.openstack.org/#/c/163876/1 which should have failed since
accessbot was not updated.
Fixed with properly wrapping main.
Change-Id: Ica8b4fa28cf9ac0009443340949ff6b32ccb9dd1
Add new test that checks that channels mentioned in gerritbot are also
in accessbot.
Enhance the irc tox target so that it runs the checks, and update Zuul
so that the job is run for changes to gerritbot.
Add channels openstack-mistral and puppet-openstack to accessbot,
openstackinfra now has access to the channels. These two channels are
already in gerritbot.
Make check_irc_access.py script executable.
Change-Id: Ic68ba9a1c60854e68817fcadb1a5df2144944af7
