4 Commits

Author SHA1 Message Date
Steve Martinelli
bd8da28abd don't fail if commands overlap
the check for overlap commands is failing, we should warn instead
of failing.

Change-Id: Ide2ea41922ef3739152713401444a9881574824d
2016-03-09 04:32:20 -05:00
Mark Vanderwiel
0f50436547 Dont include plugin definition in cmd checks
The ep for the openstack.cli.extension plugin definition
was being included in the command dict:
'orchestration': ['heatclient.osc.plugin']
Since this is not a command, should be pruned.
This was causing false positives in the overlap checking.

Change-Id: I56ec1c5d55d0efc75f59c10a44e367e330c42def
2016-03-03 15:03:29 -06:00
Mark Vanderwiel
f9fb8bf96d Add openstack client command overlap checking
With the growing number of openstack client plugins, a large list
of common objects, and the fact that any varity of plugins might be
loaded, it would be hard to stop a command overlap issue before it
get's merged. So, I took a stab at adding this to see if others
think it should be part of the command checking gate job.

Change-Id: Ifb36cb1211283987959e4cb488c5f62ffeb8ff06
2016-02-25 12:53:39 -06:00
Steve Martinelli
7159126bcd check that osc plugins do not break openstackclient
Several openstack projects are now using openstackclient for their
shell. As a result, there have been bugs raised where different
projects will use the same command, which, when released, causes
the unified command line to be broken.

This patch attempts to solve this issue before it occurs by
checking that the proposed change does not break the command line.

See mailing list post:
http://lists.openstack.org/pipermail/openstack-dev/2015-October/076272.html

Change-Id: I41b99e2ab7614ff0f49dc120e2b13751275337de
Related-Bug: 1503512
2015-12-31 20:05:32 +01:00