openstack/project-config
Code Issues Proposed changes
7eb30f7d66
project-config/roles/check-release-approval
History
Thierry Carrez 2ce6a551ac check-release-approval: handle no-review case 
When no review is posted yet, Gerrit returns simplified 'labels'
data. In particular it's missing the ['labels']['Code-Review]['all']
dictionary, which we assumed would always be present.

We should only add approvers from the reviews if the 'all' key is
provided, and otherwise just work from the owner email.

Remove all changes pushed to investigate the issue: use a narrow
query again (rather than the /detail call) and no longer catch the
exception.

Change-Id: I13fa07754e38281c63dcf0eceaa4c3b3c2715618
2020-03-20 11:39:44 +01:00
..
files check-release-approval: handle no-review case 2020-03-20 11:39:44 +01:00
tasks Define check-release-approval executor job 2020-01-10 16:52:35 +01:00
README.rst Define check-release-approval executor job 2020-01-10 16:52:35 +01:00

README.rst

Query Gerrit on release requests, checking for approvals from the PTL or release liaison corresponding to the affected deliverable. Succeed if such approval is present, fail otherwise.

Role Variables

Gerrit change number. Should be something like: 696104

Directory containing the releases repository data.

Directory containing the governance repository data.