openstack/project-config
Code Issues Proposed changes
af1c4b810c
project-config/roles/check-release-approval
History
Thierry Carrez 59188b9843 Use /detail in check-release-approval queries 
Gerrit sometimes returns a partial JSON answer, missing
the details that o=DETAILED_LABELS should trigger. This
results in false negatives in check-release-approval tests.

This cannot be reproduced easily. We put in place a retry
but the issue seems to stick on immediate retries.

As an experiment, this change switches the API call from
/changes/ID with o=DETAILED_LABELS&o=DETAILED_ACCOUNTS to
/changes/ID/detail (which includes these two options, amongst
others), to see if that would workaround the Gerrit issue.

We also remove the retry since it does not improve significantly
the situation.

Change-Id: I4de49da1b48f7b87879102a0e18e97168e39406b
2020-03-18 11:13:22 +01:00
..
files Use /detail in check-release-approval queries 2020-03-18 11:13:22 +01:00
tasks Define check-release-approval executor job 2020-01-10 16:52:35 +01:00
README.rst Define check-release-approval executor job 2020-01-10 16:52:35 +01:00

README.rst

Query Gerrit on release requests, checking for approvals from the PTL or release liaison corresponding to the affected deliverable. Succeed if such approval is present, fail otherwise.

Role Variables

Gerrit change number. Should be something like: 696104

Directory containing the releases repository data.

Directory containing the governance repository data.