e7f77f283f
libyaml now needs to Loader keyword to not throw a warning, use safe_load instead everywhere. sort_keys isn't supported for reasons surpassing understanding, so switch to ruamel.yaml for the places where we write contents back out. Our ruamel.yaml wrapper strips extra leading space, which is needed when the root object is a list. When the root object is NOT a list, it's not needed. Add a flag to the constructor to toggle the behavior. For gerrit/projects.yaml this leads to a different wrapping of description fields, which is included here. Let ruamel.yaml handle comments Since we've switched to ruamel.yaml, we don't need to strip comments. Stop stripping them. Intra-list comments aren't supported, so just remove them. Please don't ask me why we can't have a space before openstack-merlin. Change-Id: I72776774eabd4e397ee5e8bdd58b3632be8fd3a1
95 lines
2.4 KiB
Python
95 lines
2.4 KiB
Python
#!/usr/bin/env python
|
|
#
|
|
# Check that gerrit/projects.yaml changes are valid.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import argparse
|
|
import contextlib
|
|
import git
|
|
import shutil
|
|
import sys
|
|
import tempfile
|
|
import yaml
|
|
|
|
|
|
@contextlib.contextmanager
|
|
def tempdir():
|
|
try:
|
|
reqroot = tempfile.mkdtemp()
|
|
yield reqroot
|
|
finally:
|
|
shutil.rmtree(reqroot, ignore_errors=True)
|
|
|
|
|
|
def check_repo(repo_path):
|
|
found_errors = 0
|
|
|
|
print("Checking git repo '%s':" % repo_path)
|
|
try:
|
|
with tempdir() as repopath:
|
|
git.Repo.clone_from(repo_path, repopath)
|
|
print("Can be cloned")
|
|
except Exception as e:
|
|
print("Failure: %s" % e)
|
|
found_errors += 1
|
|
return found_errors
|
|
|
|
|
|
def main():
|
|
found_errors = 0
|
|
|
|
parser = argparse.ArgumentParser()
|
|
parser.add_argument('-v', '--verbose',
|
|
dest='verbose',
|
|
default=False,
|
|
action='store_true')
|
|
parser.add_argument(
|
|
'oldfile',
|
|
help='Path to old gerrit/projects.yaml',
|
|
)
|
|
parser.add_argument(
|
|
'newfile',
|
|
help='Path to new gerrit/projects.yaml',
|
|
)
|
|
args = parser.parse_args()
|
|
|
|
projects_old = yaml.safe_load(open(args.oldfile, 'r'))
|
|
projects_new = yaml.safe_load(open(args.newfile, 'r'))
|
|
|
|
ps_old = {}
|
|
for p in projects_old:
|
|
name = p.get('project')
|
|
ps_old[name] = p
|
|
|
|
for p in projects_new:
|
|
name = p.get('project')
|
|
upstream = p.get('upstream')
|
|
if name in ps_old:
|
|
p_old = ps_old[name]
|
|
upstream_old = p_old.get('upstream')
|
|
else:
|
|
upstream_old = ""
|
|
if (upstream != upstream_old and
|
|
'track-upstream' in p.get('options', [])):
|
|
print("%s has changed" % name)
|
|
found_errors += check_repo(upstream)
|
|
|
|
if found_errors:
|
|
print("Found %d error(s)" % found_errors)
|
|
sys.exit(1)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
main()
|