Ian Wienand 6349f18d40
gerrit/acl : remove deprecated copy conditions
The copy conditions here have been replaced by the "copyCondition"
query tag.  This updates the deprecated values to a new query which
does the same thing -- i.e. this should be a noop.

Mostly these are setup to have votes on labels that should be copied
on a no code change/trivial rebase, and if they're -2/+2 (i.e. max
votes are sticky).  To be exact the group of

 copyallScoresIfNoCodeChange = true
 copyAllScoresOnTrivialRebase = true
 copyMaxScore = true
 copyMinScore = true

becomes

 changekind:NO_CODE_CHANGE or changekind:TRIVIAL_REBASE \
  or is:MAX or is:MIN

Note all but ocatvia.conf, octavia-dashboard, octavia-lib, and
python-octaviaclient are copying -2/+2 votes; I feel like this is
probably a bug but I have modified these 4 projects to maintain the
same behaviour of not copying the votes.

A small number of projects copy any vote; glance.config,
kayobe.config, kolla.config, nova-specs.config, nova.config,
os-vif.config, placement.config, python-novaclient.config -- they are
replaced with is:ANY.

The old conditions have been deprecated since gerrit 3.5 [1].
Although the old conditions have not been removed yet, this will help
as we think about also changing these to submission requirements for
Gerrit 3.7.

[1] https://gerrit.googlesource.com/gerrit/+/c429ff33d944272b1f4da9f84f904f6403919ea3

Change-Id: Id13fdf588d07c1fec73978e7a69f1d9097989696
2022-12-16 16:33:09 +11:00
..
2014-09-25 11:41:04 -04:00
2022-12-01 02:22:48 +00:00