Update patch set 5
Patch Set 5: (9 comments) Patch-set: 5
This commit is contained in:
parent
6dca667d9e
commit
433678f50b
|
@ -16,6 +16,207 @@
|
|||
"message": "Thanks for the update! I\u0027ll do another round of reviews later. For now I marked all the stuff as resolved that I think is resolved. The new text imho makes a better point why this is needed for automation, great job!",
|
||||
"revId": "2457558f69ac3200a30ee41c218e16bbba85e9b9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "f30c0ace_3bc08b7f",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 32553
|
||||
},
|
||||
"writtenOn": "2024-03-07T16:00:24Z",
|
||||
"side": 1,
|
||||
"message": "LGTM, just some spelling fixes and maybe add a link to other/upstream docs or code.",
|
||||
"revId": "2457558f69ac3200a30ee41c218e16bbba85e9b9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "038a4ff6_8dad4894",
|
||||
"filename": "specs/discoverability_service.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 52,
|
||||
"author": {
|
||||
"id": 32553
|
||||
},
|
||||
"writtenOn": "2024-03-07T16:00:24Z",
|
||||
"side": 1,
|
||||
"message": "nit: space",
|
||||
"range": {
|
||||
"startLine": 52,
|
||||
"startChar": 79,
|
||||
"endLine": 52,
|
||||
"endChar": 80
|
||||
},
|
||||
"revId": "2457558f69ac3200a30ee41c218e16bbba85e9b9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "447280a0_5706bc7b",
|
||||
"filename": "specs/discoverability_service.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 68,
|
||||
"author": {
|
||||
"id": 32553
|
||||
},
|
||||
"writtenOn": "2024-03-07T16:00:24Z",
|
||||
"side": 1,
|
||||
"message": "Some",
|
||||
"range": {
|
||||
"startLine": 68,
|
||||
"startChar": 0,
|
||||
"endLine": 68,
|
||||
"endChar": 1
|
||||
},
|
||||
"revId": "2457558f69ac3200a30ee41c218e16bbba85e9b9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "b54698ff_0067d2cf",
|
||||
"filename": "specs/discoverability_service.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 71,
|
||||
"author": {
|
||||
"id": 32553
|
||||
},
|
||||
"writtenOn": "2024-03-07T16:00:24Z",
|
||||
"side": 1,
|
||||
"message": "size, network",
|
||||
"range": {
|
||||
"startLine": 71,
|
||||
"startChar": 2,
|
||||
"endLine": 71,
|
||||
"endChar": 6
|
||||
},
|
||||
"revId": "2457558f69ac3200a30ee41c218e16bbba85e9b9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "e6fab3b6_c755e4e2",
|
||||
"filename": "specs/discoverability_service.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 73,
|
||||
"author": {
|
||||
"id": 32553
|
||||
},
|
||||
"writtenOn": "2024-03-07T16:00:24Z",
|
||||
"side": 1,
|
||||
"message": "nit: locally",
|
||||
"range": {
|
||||
"startLine": 73,
|
||||
"startChar": 29,
|
||||
"endLine": 73,
|
||||
"endChar": 35
|
||||
},
|
||||
"revId": "2457558f69ac3200a30ee41c218e16bbba85e9b9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "6829557f_95c52e3c",
|
||||
"filename": "specs/discoverability_service.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 116,
|
||||
"author": {
|
||||
"id": 32553
|
||||
},
|
||||
"writtenOn": "2024-03-07T16:00:24Z",
|
||||
"side": 1,
|
||||
"message": "we should probably link the docs/file here?",
|
||||
"range": {
|
||||
"startLine": 115,
|
||||
"startChar": 0,
|
||||
"endLine": 116,
|
||||
"endChar": 9
|
||||
},
|
||||
"revId": "2457558f69ac3200a30ee41c218e16bbba85e9b9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "597d22e4_94c8b961",
|
||||
"filename": "specs/discoverability_service.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 146,
|
||||
"author": {
|
||||
"id": 32553
|
||||
},
|
||||
"writtenOn": "2024-03-07T16:00:24Z",
|
||||
"side": 1,
|
||||
"message": "nit:Discovery",
|
||||
"range": {
|
||||
"startLine": 146,
|
||||
"startChar": 0,
|
||||
"endLine": 146,
|
||||
"endChar": 9
|
||||
},
|
||||
"revId": "2457558f69ac3200a30ee41c218e16bbba85e9b9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "efc24afc_dc139ca1",
|
||||
"filename": "specs/discoverability_service.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 209,
|
||||
"author": {
|
||||
"id": 32553
|
||||
},
|
||||
"writtenOn": "2024-03-07T16:00:24Z",
|
||||
"side": 1,
|
||||
"message": "nit: whitespace",
|
||||
"range": {
|
||||
"startLine": 209,
|
||||
"startChar": 0,
|
||||
"endLine": 209,
|
||||
"endChar": 2
|
||||
},
|
||||
"revId": "2457558f69ac3200a30ee41c218e16bbba85e9b9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "de74b260_0330ee75",
|
||||
"filename": "specs/discoverability_service.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 223,
|
||||
"author": {
|
||||
"id": 32553
|
||||
},
|
||||
"writtenOn": "2024-03-07T16:00:24Z",
|
||||
"side": 1,
|
||||
"message": "sophisticated",
|
||||
"range": {
|
||||
"startLine": 223,
|
||||
"startChar": 22,
|
||||
"endLine": 223,
|
||||
"endChar": 35
|
||||
},
|
||||
"revId": "2457558f69ac3200a30ee41c218e16bbba85e9b9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue