From 261f5649aef71d6cae4a9112cbd44fa8c392f3c2 Mon Sep 17 00:00:00 2001
From: ZhongShengping <chdzsp@163.com>
Date: Thu, 22 Mar 2018 09:52:26 +0800
Subject: [PATCH] Add pool_timeout option

Add pool_timeout option to configure this value for pool_timeout with
SQLAlchemy.

Change-Id: Id6e7a30c6a94d6bf10ed924003dcf672e331c647
Closes-Bug: #1757581
---
 manifests/db.pp                                             | 6 ++++++
 .../add-pool_timeout-option-for-db-e14f111a41b4b3af.yaml    | 5 +++++
 spec/classes/aodh_db_spec.rb                                | 3 +++
 3 files changed, 14 insertions(+)
 create mode 100644 releasenotes/notes/add-pool_timeout-option-for-db-e14f111a41b4b3af.yaml

diff --git a/manifests/db.pp b/manifests/db.pp
index d1dd8923..5fe2869e 100644
--- a/manifests/db.pp
+++ b/manifests/db.pp
@@ -38,6 +38,10 @@
 #   If set, use this value for max_overflow with sqlalchemy.
 #   (Optional) Defaults to $::os_service_default.
 #
+# [*database_pool_timeout*]
+#   (Optional) If set, use this value for pool_timeout with SQLAlchemy.
+#   Defaults to $::os_service_default
+#
 class aodh::db (
   $database_db_max_retries = $::os_service_default,
   $database_connection     = 'sqlite:////var/lib/aodh/aodh.sqlite',
@@ -47,6 +51,7 @@ class aodh::db (
   $database_max_retries    = $::os_service_default,
   $database_retry_interval = $::os_service_default,
   $database_max_overflow   = $::os_service_default,
+  $database_pool_timeout   = $::os_service_default,
 ) {
 
   include ::aodh::deps
@@ -68,5 +73,6 @@ class aodh::db (
     max_retries    => $database_max_retries_real,
     retry_interval => $database_retry_interval_real,
     max_overflow   => $database_max_overflow_real,
+    pool_timeout   => $database_pool_timeout,
   }
 }
diff --git a/releasenotes/notes/add-pool_timeout-option-for-db-e14f111a41b4b3af.yaml b/releasenotes/notes/add-pool_timeout-option-for-db-e14f111a41b4b3af.yaml
new file mode 100644
index 00000000..be303891
--- /dev/null
+++ b/releasenotes/notes/add-pool_timeout-option-for-db-e14f111a41b4b3af.yaml
@@ -0,0 +1,5 @@
+---
+features:
+  - |
+    Adds the pool_timeout option for configuring oslo.db. This will
+    configure this value for pool_timeout with SQLAlchemy.
diff --git a/spec/classes/aodh_db_spec.rb b/spec/classes/aodh_db_spec.rb
index 350068a6..4c64405b 100644
--- a/spec/classes/aodh_db_spec.rb
+++ b/spec/classes/aodh_db_spec.rb
@@ -14,6 +14,7 @@ describe 'aodh::db' do
         :max_retries    => '<SERVICE DEFAULT>',
         :retry_interval => '<SERVICE DEFAULT>',
         :max_overflow   => '<SERVICE DEFAULT>',
+        :pool_timeout   => '<SERVICE DEFAULT>',
       )}
 
     end
@@ -28,6 +29,7 @@ describe 'aodh::db' do
           :database_max_retries    => '11',
           :database_retry_interval => '11',
           :database_max_overflow   => '21',
+          :database_pool_timeout   => '21',
         }
       end
       it { is_expected.to contain_oslo__db('aodh_config').with(
@@ -39,6 +41,7 @@ describe 'aodh::db' do
         :max_retries    => '11',
         :retry_interval => '11',
         :max_overflow   => '21',
+        :pool_timeout   => '21',
       )}
 
     end