Add strict validation about boolean parameters

This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.

Change-Id: I73444acddba8818dfcee5d2b2bca52c7e4cf3451

manifests/api.pp

@@ -66,11 +66,14 @@ class aodh::api (
   $gnocchi_external_domain_name   = 'Default',
 ) inherits aodh::params {
 
-
   include aodh::deps
   include aodh::params
   include aodh::policy
 
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+  validate_legacy(Boolean, 'validate_bool', $sync_db)
+
   if $auth_strategy == 'keystone' {
     include aodh::keystone::authtoken
   }

manifests/evaluator.pp

@@ -43,6 +43,9 @@ class aodh::evaluator (
   include aodh::deps
   include aodh::params
 
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+
   aodh_config {
     'evaluator/evaluation_interval':    value => $evaluation_interval;
     'DEFAULT/event_alarm_cache_ttl':    value => $event_alarm_cache_ttl;

manifests/listener.pp

@@ -43,6 +43,9 @@ class aodh::listener (
   include aodh::deps
   include aodh::params
 
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+
   aodh_config {
     'listener/workers':           value => $workers;
     'listener/event_alarm_topic': value => $event_alarm_topic;

manifests/notifier.pp

@@ -39,6 +39,9 @@ class aodh::notifier (
   include aodh::deps
   include aodh::params
 
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+
   aodh_config {
     'notifier/workers':       value => $workers;
     'notifier/batch_size':    value => $batch_size;