openstack
/
puppet-aodh
Code Issues Proposed changes

coordination: Remove deprecated heartbeat 

The parameter was deprecated during Yoga cycle[1] in favor of the new
heartbeat_interval parameter.

[1] 49eb825204

Change-Id: I03d217663445001fc48f9192774ae6b680d2d7f9
This commit is contained in:
Takashi Kajinami 2022-05-20 00:33:03 +09:00
parent 4ec7119fc6
commit cc2cec0491
2 changed files with 5 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
manifests/coordination.pp
View File

@ -23,20 +23,11 @@
# group
# Defaults to $::os_service_default
#
# DEPRECATED PARAMETERS
#
# [*heartbeat*]
# (Optional) Number of seconds between hearbeats for distributed
# coordintation.
# Defaults to undef
#
class aodh::coordination (
$backend_url = $::os_service_default,
$heartbeat_interval = $::os_service_default,
$retry_backoff = $::os_service_default,
$max_retry_interval = $::os_service_default,
# DEPRECATED PARAMETERS
$heartbeat = undef,
) {
include aodh::deps
@ -47,23 +38,13 @@ class aodh::coordination (
$backend_url_real = $backend_url
}
if $heartbeat != undef {
warning('The heartbeat parmaeter is deprecated. Use the heartbeat_interval parameter instead')
}
$heartbeat_interval_real = pick($heartbeat, $heartbeat_interval)
oslo::coordination{ 'aodh_config':
backend_url => $backend_url_real
}
aodh_config {
'coordination/heartbeat_interval': value => $heartbeat_interval_real;
'coordination/heartbeat_interval': value => $heartbeat_interval;
'coordination/retry_backoff': value => $retry_backoff;
'coordination/max_retry_interval': value => $max_retry_interval;
}
# TODO(tkajinam): Remove this when the hearbeat parameter is removed.
aodh_config {
'coordination/heartbeat': ensure => absent;
}
}

4
releasenotes/notes/remove-coordination-heartbeat-29c0844c7546f2b9.yaml Normal file
View File

@ -0,0 +1,4 @@
---
upgrade:
- |
The ``aodh::coordination::heartbeat`` parameter has been removed.