This change updates the module to use the rspec-puppet-facts as defined
in the puppet-openstack_spec_helper.
Since this module was last updated to use rspec-puppet-facts, a few
additional tests were missed. This change updates the last two tests to
This change adds the rspec-puppet-facts gem to the spec helper so that
we can centralize the management of the base operating systems that we
support. rspec-puppet-facts allows us to simplify our unit tests and
provides a more complete list of Operating Systems and their associated
facts for the unit tests. With this change we can now loop over and
test CentOS, Debian, Fedora, RedHat, and Ubuntu by simply providing a
list of supported os to rspec-puppet-facts.
Additionally this change includes a central object for managing our
supported os list for rspec-puppet-facts and providing our default facts
like os_service_default. This central object should replace the usage of
@default_facts within the unit tests for each module.
This change switches the aodh module to use the os_service_default
fact for configuration options that default to '<SERVICE DEFAULT>'.
Signed-off-by: Gael Chamoulaud <firstname.lastname@example.org>