openstack/puppet-barbican
Code Issues Proposed changes

Update patch set 1

Browse Source 
Patch Set 1: Code-Review-1

(2 comments)

Patch-set: 1
Label: Code-Review=-1
This commit is contained in:
Gerrit User 10873 2015-10-02 10:42:43 +00:00 committed by Gerrit Code Review
parent da12ec8c93
commit 288bf1dc90
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
fc77269fd317146c17d4440550571093bf84a667 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "9a1a9d01_4513e85c",
"filename": "manifests/db/sync.pp",
"patchSetId": 1
},
"lineNbr": 15,
"author": {
"id": 10873
},
"writtenOn": "2015-10-02T10:42:43Z",
"side": 1,
"message": "barbican doesn\u0027t have a barbican-manage command. We do, however provide a barbican-db-manage command, but that contains different options.\n\n$ barbican-db-manage --help\nusage: barbican-db-manage [-h] [--dburl DBURL]\n {revision,upgrade,history,current} ...\n\nBarbican DB manager.\n\noptional arguments:\n -h, --help show this help message and exit\n --dburl DBURL, -d DBURL\n URL to the database.\n\nsubcommands:\n Action to perform\n\n {revision,upgrade,history,current}\n revision Create a new DB version file.\n upgrade Upgrade to a future version DB version file\n history List changeset scripts in chronological order.\n current Display the current revision for a database.",
"revId": "fc77269fd317146c17d4440550571093bf84a667",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9a1a9d01_851fc05a",
"filename": "manifests/db/sync.pp",
"patchSetId": 1
},
"lineNbr": 24,
"author": {
"id": 10873
},
"writtenOn": "2015-10-02T10:42:43Z",
"side": 1,
"message": "Initially Barbican will autogenerate the database schema if the configuration is provided correctly (target database and credentials). Subsequently, if there is need for an update, you need to run\n\n$ barbican-db-manage upgrade",
"revId": "fc77269fd317146c17d4440550571093bf84a667",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}