openstack
/
puppet-barbican
Code Issues Proposed changes

Do not test detail of keystone::resource::service_identity 

... but test interfaces of that resource type. This helps us avoid
direct breakage caused by any change in puppet-keystone.

Change-Id: Ib132565db945d541fdc5f7604d6e7518b9bc0dd7
This commit is contained in:
Takashi Kajinami 2021-09-21 16:41:45 +09:00
parent cfc1fc6ea2
commit 6b59016afc
1 changed files with 50 additions and 119 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

169
spec/classes/barbican_keystone_auth_spec.rb
View File

@ -1,137 +1,68 @@
#
# Copyright (C) 2016 Red Hat Inc. <licensing@redhat.com>
#
# Author: Ade Lee <alee@redhat.com>
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# Unit tests for barbican::keystone::auth class
# Unit tests for barbican::keystone::auth
#
require 'spec_helper'
describe 'barbican::keystone::auth' do
shared_examples 'barbican::keystone::auth' do
shared_examples_for 'barbican::keystone::auth' do
context 'with default class parameters' do
let :params do
{
:password => 'barbican_password',
:tenant => 'foobar'
}
{ :password => 'barbican_password' }
end
it { should contain_keystone_user('barbican').with(
:ensure => 'present',
:password => 'barbican_password',
)}
it { should contain_keystone_user_role('barbican@foobar').with(
:ensure => 'present',
:roles => ['admin']
)}
it { should contain_keystone_service('barbican::key-manager').with(
:ensure => 'present',
:description => 'Key management Service'
)}
it { should contain_keystone_endpoint('RegionOne/barbican::key-manager').with(
:ensure => 'present',
:public_url => 'http://127.0.0.1:9311',
:admin_url => 'http://127.0.0.1:9311',
:internal_url => 'http://127.0.0.1:9311',
)}
it { is_expected.to contain_keystone__resource__service_identity('barbican').with(
:configure_user => true,
:configure_user_role => true,
:configure_endpoint => true,
:service_name => 'barbican',
:service_type => 'key-manager',
:service_description => 'Key management Service',
:region => 'RegionOne',
:auth_name => 'barbican',
:password => 'barbican_password',
:email => 'barbican@localhost',
:tenant => 'services',
:public_url => 'http://127.0.0.1:9311',
:internal_url => 'http://127.0.0.1:9311',
:admin_url => 'http://127.0.0.1:9311',
) }
end
context 'when overriding URL parameters' do
context 'when overriding parameters' do
let :params do
{
:password => 'barbican_password',
:public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81'
}
end
it { should contain_keystone_endpoint('RegionOne/barbican::key-manager').with(
:ensure => 'present',
:public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81'
)}
end
context 'when overriding auth name' do
let :params do
{
:password => 'foo',
:auth_name => 'barbicany'
}
end
it { should contain_keystone_user('barbicany') }
it { should contain_keystone_user_role('barbicany@services') }
it { should contain_keystone_service('barbican::key-manager') }
it { should contain_keystone_endpoint('RegionOne/barbican::key-manager') }
end
context 'when overriding service name' do
let :params do
{
:service_name => 'barbican_service',
:auth_name => 'barbican',
:password => 'barbican_password'
}
end
it { should contain_keystone_user('barbican') }
it { should contain_keystone_user_role('barbican@services') }
it { should contain_keystone_service('barbican_service::key-manager') }
it { should contain_keystone_endpoint('RegionOne/barbican_service::key-manager') }
end
context 'when disabling user configuration' do
let :params do
{
:password => 'barbican_password',
:configure_user => false
}
end
it { should_not contain_keystone_user('barbican') }
it { should contain_keystone_user_role('barbican@services') }
it { should contain_keystone_service('barbican::key-manager').with(
:ensure => 'present',
:description => 'Key management Service'
)}
end
context 'when disabling user and user role configuration' do
let :params do
{
:password => 'barbican_password',
{ :password => 'barbican_password',
:auth_name => 'alt_barbican',
:email => 'alt_barbican@alt_localhost',
:tenant => 'alt_service',
:configure_endpoint => false,
:configure_user => false,
:configure_user_role => false
}
:configure_user_role => false,
:service_description => 'Alternative Key management Service',
:service_name => 'alt_service',
:service_type => 'alt_key-manager',
:region => 'RegionTwo',
:public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81' }
end
it { should_not contain_keystone_user('barbican') }
it { should_not contain_keystone_user_role('barbican@services') }
it { should contain_keystone_service('barbican::key-manager').with(
:ensure => 'present',
:description => 'Key management Service'
)}
it { is_expected.to contain_keystone__resource__service_identity('barbican').with(
:configure_user => false,
:configure_user_role => false,
:configure_endpoint => false,
:service_name => 'alt_service',
:service_type => 'alt_key-manager',
:service_description => 'Alternative Key management Service',
:region => 'RegionTwo',
:auth_name => 'alt_barbican',
:password => 'barbican_password',
:email => 'alt_barbican@alt_localhost',
:tenant => 'alt_service',
:public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81',
) }
end
end