openstack
/
puppet-barbican
Code Issues Proposed changes

Ensure package_ensure takes a supported value 

puppetlabs-stdlib provides the type to validate a parameter which is
used to define ensure of a package resource. This adds validation using
that type.

Change-Id: Icd4592fa8b53f5b3c9224df5f1a866ae21c2b0d4
This commit is contained in:
Takashi Kajinami 2023-06-22 15:37:19 +09:00
parent 2079fb1ff5
commit 7c37274b14
5 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/api.pp
View File

@ -231,7 +231,7 @@
# Defaults to $facts['os_service_default']
#
class barbican::api (
$package_ensure = 'present',
Stdlib::Ensure::Package $package_ensure = 'present',
$bind_host = '0.0.0.0',
$bind_port = '9311',
$host_href = undef,

4
manifests/init.pp
View File

@ -14,8 +14,8 @@
# Defaults to false.
#
class barbican(
$package_ensure = 'present',
$purge_config = false,
Stdlib::Ensure::Package $package_ensure = 'present',
$purge_config = false,
) {
include barbican::deps

2
manifests/keystone/notification.pp
View File

@ -38,7 +38,7 @@ class barbican::keystone::notification (
$keystone_notification_topic = $facts['os_service_default'],
$keystone_notification_allow_requeue = $facts['os_service_default'],
$keystone_notification_thread_pool_size = $facts['os_service_default'],
$package_ensure = 'present',
Stdlib::Ensure::Package $package_ensure = 'present',
Boolean $manage_service = true,
) {

10
manifests/retry_scheduler.pp
View File

@ -25,11 +25,11 @@
# Defaults to $facts['os_service_default']
#
class barbican::retry_scheduler (
$package_ensure = 'present',
Boolean $manage_service = true,
Boolean $enabled = true,
$initial_delay_seconds = $facts['os_service_default'],
$periodic_interval_max_seconds = $facts['os_service_default'],
Stdlib::Ensure::Package $package_ensure = 'present',
Boolean $manage_service = true,
Boolean $enabled = true,
$initial_delay_seconds = $facts['os_service_default'],
$periodic_interval_max_seconds = $facts['os_service_default'],
){
include barbican::deps

6
manifests/worker.pp
View File

@ -34,9 +34,9 @@
# Defaults to true
#
class barbican::worker (
$package_ensure = 'present',
Boolean $manage_service = true,
Boolean $enabled = true,
Stdlib::Ensure::Package $package_ensure = 'present',
Boolean $manage_service = true,
Boolean $enabled = true,
) inherits barbican::params {
include barbican::deps