Remove deprecated client_package_ensure

The parameter has had no effect for several cycles and was formally
deprecated during the previous cycle[1].

[1] 6c60f0d67e

Change-Id: Ib94130cf8215e3a832e4d44645ce90a2450627d2

manifests/api.pp

@@ -232,11 +232,6 @@
 #
 # DEPRECATED PARAMETERS
 #
-# [*client_package_ensure*]
-#   (optional) Desired ensure state of the client package.
-#   accepts latest or specific versions.
-#   Defaults to undef
-#
 # [*use_ssl*]
 #   (optional) Enable SSL on the API server
 #   Defaults to undef
@@ -301,7 +296,6 @@ class barbican::api (
   $max_limit_paging                              = $::os_service_default,
   $default_limit_paging                          = $::os_service_default,
   # DEPRECATED PARAMETERS
-  $client_package_ensure                         = undef,
   $use_ssl                                       = undef,
   $ca_file                                       = undef,
   $cert_file                                     = undef,
@@ -313,10 +307,6 @@ class barbican::api (
   include barbican::client
   include barbican::policy
 
-  if $client_package_ensure != undef {
-    warning('The client_package_ensure is deprecated and has no effect.')
-  }
-
   package { 'barbican-api':
     ensure => $package_ensure,
     name   => $::barbican::params::api_package_name,

releasenotes/notes/remove-client_package_ensure-47d65842e214f749.yaml

@@ -0,0 +1,4 @@
+---
+upgrade:
+  - |
+    The ``barbican::api::client_package_ensure`` parameter has been removed.