openstack
/
puppet-barbican
Code Issues Proposed changes

Do not validate database_connection format 

Currently we validate database_connection in 2 layers, each puppet
modules and puppet-oslo, however this makes it difficult to maintain
validation pattern because we always need to fix both.
This patch removes the validation from each puppet modules so that
we need to maitain only one place, puppet-oslo to update validation
logic.

Change-Id: I47ef221165959090294f51011e1a8eb454ad91bc
This commit is contained in:
Takashi Kajinami 2020-08-30 23:56:13 +09:00
parent 7c934e82cc
commit aaca360974
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
manifests/db.pp
View File

@ -74,9 +74,6 @@ class barbican::db (
warning('The database_min_pool_size parameter is deprecated, and will be removed in a future release.')
}
validate_legacy(Oslo::Dbconn, 'validate_re', $database_connection,
['^(sqlite|mysql(\+pymysql)?|postgresql):\/\/(\S+:\S+@\S+\/\S+)?'])
oslo::db { 'barbican_config':
connection => $database_connection,
connection_recycle_time => $database_connection_recycle_time,