openstack
/
puppet-barbican
Code Issues Proposed changes

Merge "vault: Drop redundant hard-coded default of use_ssl"

This commit is contained in:
Zuul 2023-12-15 18:21:08 +00:00 committed by Gerrit Code Review
parent f5b72e871d 01ececb278
commit b23fc4b8cb
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/plugins/vault.pp
View File

@ -26,7 +26,7 @@
#
# [*use_ssl*]
# (optional) Enable or disable SSL
# Defaults to false
# Defaults to $facts['os_service_default']
#
# [*ssl_ca_crt_file*]
# (optional) Set the ssl CA cert file
@ -42,7 +42,7 @@ class barbican::plugins::vault (
$approle_role_id = $facts['os_service_default'],
$approle_secret_id = $facts['os_service_default'],
$kv_mountpoint = $facts['os_service_default'],
$use_ssl = false,
$use_ssl = $facts['os_service_default'],
$ssl_ca_crt_file = $facts['os_service_default'],
$global_default = false,
) {

2
spec/classes/barbican_plugins_vault_spec.rb
View File

@ -91,7 +91,7 @@ describe 'barbican::plugins::vault' do
is_expected.to contain_barbican_config('vault_plugin/kv_mountpoint') \
.with_value('<SERVICE DEFAULT>')
is_expected.to contain_barbican_config('vault_plugin/use_ssl') \
.with_value('false')
.with_value('<SERVICE DEFAULT>')
is_expected.to contain_barbican_config('vault_plugin/ssl_ca_crt_file') \
.with_value('<SERVICE DEFAULT>')
is_expected.to contain_barbican_config(