75 lines
2.4 KiB
Plaintext
75 lines
2.4 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "4e12ef16_ffcae4ba",
|
|
"filename": "manifests/keystone/notification.pp",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 62,
|
|
"author": {
|
|
"id": 9816
|
|
},
|
|
"writtenOn": "2023-06-15T17:08:41Z",
|
|
"side": 1,
|
|
"message": "Alternatively we can use `Variant[String[\u0027\u003cSERVICE DEFAULT\u003e\u0027], Boolean]` but I want to get some agreement about handling of service default before doing this, so I\u0027ve decided this implementation for now.",
|
|
"range": {
|
|
"startLine": 62,
|
|
"startChar": 25,
|
|
"endLine": 62,
|
|
"endChar": 53
|
|
},
|
|
"revId": "d3724a40b23e2ab952529cc7dcdf452e133b314b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "8500bd3c_d7c921ad",
|
|
"filename": "manifests/keystone/notification.pp",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 62,
|
|
"author": {
|
|
"id": 7888
|
|
},
|
|
"writtenOn": "2023-06-15T20:51:24Z",
|
|
"side": 1,
|
|
"message": "You mean Variant[Enum[\u0027\u003cSERVICE DEFAULT\u003e\u0027], Boolean] ;)\n\nBetter, add type definition and use, see:\nChange-Id: Ic2b969f9b99d1748c80edb691f38f4451e499a80",
|
|
"parentUuid": "4e12ef16_ffcae4ba",
|
|
"range": {
|
|
"startLine": 62,
|
|
"startChar": 25,
|
|
"endLine": 62,
|
|
"endChar": 53
|
|
},
|
|
"revId": "d3724a40b23e2ab952529cc7dcdf452e133b314b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "dbc394ac_8207dbd6",
|
|
"filename": "manifests/keystone/notification.pp",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 62,
|
|
"author": {
|
|
"id": 9816
|
|
},
|
|
"writtenOn": "2023-06-15T22:15:03Z",
|
|
"side": 1,
|
|
"message": "yes Enum. We can probably define OSBoolean which allows SERVICE DEFAULT as well as actual Boolean and String representation, but again we need to agree with the patterns we allow for each option types so I\u0027d avoid creating the type now and focus on removing the validate_legacy.",
|
|
"parentUuid": "8500bd3c_d7c921ad",
|
|
"range": {
|
|
"startLine": 62,
|
|
"startChar": 25,
|
|
"endLine": 62,
|
|
"endChar": 53
|
|
},
|
|
"revId": "d3724a40b23e2ab952529cc7dcdf452e133b314b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |