openstack/puppet-ceilometer
Code Issues Proposed changes

Ensure proper type for polling_meters

Browse Source 
This parameter requires an array value. Let's validate the input at
the parameter layer to avoid unexpected failure within the lower logic.

Change-Id: Ib370a7c6930398675e8c18011e9ea8d5a90d0525
This commit is contained in:
Takashi Kajinami 2023-06-22 16:10:11 +09:00
parent 51985be052
commit 180cb23ce0
1 changed files with 17 additions and 17 deletions

34
manifests/agent/polling.pp

@ -82,23 +82,23 @@
# Defaults to $facts['os_service_default'].
#
class ceilometer::agent::polling (
Boolean $manage_service = true,
Boolean $enabled = true,
Boolean $separate_services = false,
$package_ensure = 'present',
Boolean $manage_user = true,
Boolean $central_namespace = true,
Boolean $compute_namespace = true,
Boolean $ipmi_namespace = true,
$instance_discovery_method = $facts['os_service_default'],
$resource_update_interval = $facts['os_service_default'],
$resource_cache_expiry = $facts['os_service_default'],
Boolean $manage_polling = false,
$polling_interval = 600,
$polling_meters = $::ceilometer::params::polling_meters,
Optional[Hash]$polling_config = undef,
$batch_size = $facts['os_service_default'],
$tenant_name_discovery = $facts['os_service_default'],
Boolean $manage_service = true,
Boolean $enabled = true,
Boolean $separate_services = false,
$package_ensure = 'present',
Boolean $manage_user = true,
Boolean $central_namespace = true,
Boolean $compute_namespace = true,
Boolean $ipmi_namespace = true,
$instance_discovery_method = $facts['os_service_default'],
$resource_update_interval = $facts['os_service_default'],
$resource_cache_expiry = $facts['os_service_default'],
Boolean $manage_polling = false,
$polling_interval = 600,
Array[String[1]] $polling_meters = $::ceilometer::params::polling_meters,
Optional[Hash]$polling_config = undef,
$batch_size = $facts['os_service_default'],
$tenant_name_discovery = $facts['os_service_default'],
) inherits ceilometer {
include ceilometer::deps