openstack
/
puppet-ceilometer
Code Issues Proposed changes

Use package resource directly 

... instead of using ensure_resource to define a package resource,
because it is not expected that ceilometer packages are managed outside
of puppet-ceilometer.

Change-Id: I541450707b64277b30d55f136d57b8cf4443cfd4
This commit is contained in:
Takashi Kajinami 2021-09-24 16:49:05 +09:00
parent 317147f670
commit 1dd5ddb827
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
manifests/agent/notification.pp
View File

@ -117,12 +117,11 @@ class ceilometer::agent::notification (
$workers_real = $workers
}
ensure_resource('package', [$::ceilometer::params::agent_notification_package_name],
{
ensure => $package_ensure,
tag => ['openstack', 'ceilometer-package']
}
)
package { 'ceilometer-notification':
ensure => $package_ensure,
name => $::ceilometer::params::agent_notification_package_name,
tag => ['openstack', 'ceilometer-package']
}
if $manage_service {
if $enabled {

3
spec/classes/ceilometer_agent_notification_spec.rb
View File

@ -37,8 +37,9 @@ describe 'ceilometer::agent::notification' do
it { is_expected.to contain_class('ceilometer::params') }
it 'installs ceilometer agent notification package' do
is_expected.to contain_package(platform_params[:agent_notification_package_name]).with(
is_expected.to contain_package('ceilometer-notification').with(
:ensure => 'present',
:name => platform_params[:agent_notification_package_name],
:tag => ['openstack', 'ceilometer-package'],
)
end