openstack/puppet-ceilometer
Code Issues Proposed changes

Drop redundant hard-coded default of notification topics

Browse Source 
The current value exactly matches the service default value.

Change-Id: Ia598e4ebcb078b99c417e7bb578359f730138127
This commit is contained in:
Takashi Kajinami 2024-09-28 01:04:38 +09:00
parent cb6cb71752
commit 3c31dcded7
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/init.pp
View File

@ -25,7 +25,7 @@
#
# [*notification_topics*]
# (Optional) AMQP topic used for OpenStack notifications (list value)
# Defaults to 'notifications'.
# Defaults to $facts['os_service_default']
#
# [*notification_driver*]
# (optional) Driver or drivers to handle sending notifications.
@ -177,7 +177,7 @@ class ceilometer(
$http_timeout = $facts['os_service_default'],
$max_parallel_requests = $facts['os_service_default'],
$notification_transport_url = $facts['os_service_default'],
$notification_topics = ['notifications'],
$notification_topics = $facts['os_service_default'],
$notification_driver = $facts['os_service_default'],
$notification_retry = $facts['os_service_default'],
$package_ensure = 'present',

2
spec/classes/ceilometer_init_spec.rb
View File

@ -89,7 +89,7 @@ describe 'ceilometer' do
is_expected.to contain_oslo__messaging__notifications('ceilometer_config').with(
:transport_url => '<SERVICE DEFAULT>',
:driver => '<SERVICE DEFAULT>',
:topics => ['notifications'],
:topics => '<SERVICE DEFAULT>',
:retry => '<SERVICE DEFAULT>',
)
end