openstack
/
puppet-ceilometer
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Takashi Kajinami replied on the change"}
Attention: {"person_ident":"Gerrit User 26721 \u003c26721@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Takashi Kajinami replied on the change"}
This commit is contained in:
Gerrit User 9816 2022-05-14 13:19:30 +00:00 committed by Gerrit Code Review
parent 251c042252
commit 5ce32ca9bd
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7
View File

@ -68,6 +68,24 @@
"message": "@Takashi do you have any further comments about this change?",
"revId": "5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e6181112_194f38fd",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 9816
},
"writtenOn": "2022-05-14T13:19:30Z",
"side": 1,
"message": "Sorry I was off during first week of May and missed this after coming back holidays.\n\nThough I understand part of your thought, do you mind explaining a few more details, expecialy about the way you use the puppet module with such container deployment ? AFAIK in Kolla the users are created during building the packages, so as long as you execute puppet inside containers then you don\u0027t need this change as the puppet execution looks up the user inside container images. This is how we actually use puppet modules in TripleO and we have never seen any issue with that.\n\nYou might be able to use puppet modules to generate config files, but the current modules do not support that use case perfectly (eg. There are some packages still forcefully installed. A few configuration tasks like apache files requires the packages are installed) and I believe we still need some amount of work, which I\u0027m not sure could be worth doing.",
"parentUuid": "acbe1e09_6b5e4639",
"revId": "5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}