openstack/puppet-ceilometer
Code Issues Proposed changes

Fix typos in parameter descriptions and tests

Browse Source 
Change-Id: Id17358fce48468284f162a6de35840d439871cd5
This commit is contained in:
Rajesh Tailor 2022-06-17 19:06:27 +05:30
parent 210fdec48f
commit 7d3af77f01
6 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -24,7 +24,7 @@ Overview
-------- --------
The ceilometer module is part of [OpenStack](https://opendev.org/openstack), an effort by the The ceilometer module is part of [OpenStack](https://opendev.org/openstack), an effort by the
OpenStack infrastructure team to provice continuous integration testing and code review for OpenStack infrastructure team to provide continuous integration testing and code review for
OpenStack and OpenStack community projects as part of the core software. The module itself OpenStack and OpenStack community projects as part of the core software. The module itself
is used to flexibly configure and manage the metering service for OpenStack. is used to flexibly configure and manage the metering service for OpenStack.

6
manifests/cache.pp
View File

@ -108,7 +108,7 @@
# Defaults to true # Defaults to true
# #
# [*tls_enabled*] # [*tls_enabled*]
# (Optional) Global toggle for TLS usage when comunicating with # (Optional) Global toggle for TLS usage when communicating with
# the caching servers. # the caching servers.
# Default to $::os_service_default # Default to $::os_service_default
# #
@ -128,7 +128,7 @@
# #
# [*tls_keyfile*] # [*tls_keyfile*]
# (Optional) Path to a single file containing the client's private # (Optional) Path to a single file containing the client's private
# key in. Otherwhise the private key will be taken from the file # key in. Otherwise the private key will be taken from the file
# specified in tls_certfile. If tls_enabled is False, this option # specified in tls_certfile. If tls_enabled is False, this option
# is ignored. # is ignored.
# Default to $::os_service_default # Default to $::os_service_default
@ -144,7 +144,7 @@
# (Optional) Enable retry client mechanisms to handle failure. # (Optional) Enable retry client mechanisms to handle failure.
# Those mechanisms can be used to wrap all kind of pymemcache # Those mechanisms can be used to wrap all kind of pymemcache
# clients. The wrapper allows you to define how many attempts # clients. The wrapper allows you to define how many attempts
# to make and how long to wait between attemots. # to make and how long to wait between attempts.
# Default to $::os_service_default # Default to $::os_service_default
# #
# [*retry_attempts*] # [*retry_attempts*]

6
manifests/init.pp
View File

@ -241,7 +241,7 @@
# Defaults to undef # Defaults to undef
# #
# [*cache_tls_enabled*] # [*cache_tls_enabled*]
# (Optional) Global toggle for TLS usage when comunicating with # (Optional) Global toggle for TLS usage when communicating with
# the caching servers. # the caching servers.
# Default to undef # Default to undef
# #
@ -261,7 +261,7 @@
# #
# [*cache_tls_keyfile*] # [*cache_tls_keyfile*]
# (Optional) Path to a single file containing the client's private # (Optional) Path to a single file containing the client's private
# key in. Otherwhise the private key will be taken from the file # key in. Otherwise the private key will be taken from the file
# specified in tls_certfile. If tls_enabled is False, this option # specified in tls_certfile. If tls_enabled is False, this option
# is ignored. # is ignored.
# Default to undef # Default to undef
@ -277,7 +277,7 @@
# (Optional) Enable retry client mechanisms to handle failure. # (Optional) Enable retry client mechanisms to handle failure.
# Those mechanisms can be used to wrap all kind of pymemcache # Those mechanisms can be used to wrap all kind of pymemcache
# clients. The wrapper allows you to define how many attempts # clients. The wrapper allows you to define how many attempts
# to make and how long to wait between attemots. # to make and how long to wait between attempts.
# Default to undef # Default to undef
# #
# [*cache_retry_attempts*] # [*cache_retry_attempts*]

2
manifests/keystone/auth.pp
View File

@ -66,7 +66,7 @@ class ceilometer::keystone::auth (
validate_legacy(String, 'validate_string', $password) validate_legacy(String, 'validate_string', $password)
# Ceilometer rquires only its user, project, and role assignment. # Ceilometer requires only its user, project, and role assignment.
# service and endpoint should be disabled since ceilometer-api has been removed. # service and endpoint should be disabled since ceilometer-api has been removed.
keystone::resource::service_identity { 'ceilometer': keystone::resource::service_identity { 'ceilometer':
configure_user => $configure_user, configure_user => $configure_user,

2
spec/classes/ceilometer_agent_service_credentials_spec.rb
View File

@ -12,7 +12,7 @@ describe 'ceilometer::agent::service_credentials' do
shared_examples_for 'ceilometer::agent::service_credentials' do shared_examples_for 'ceilometer::agent::service_credentials' do
context 'wtih default values' do context 'with default values' do
it 'configures authentication' do it 'configures authentication' do
is_expected.to contain_ceilometer_config('service_credentials/auth_url').with_value('http://localhost:5000') is_expected.to contain_ceilometer_config('service_credentials/auth_url').with_value('http://localhost:5000')
is_expected.to contain_ceilometer_config('service_credentials/region_name').with_value('<SERVICE DEFAULT>') is_expected.to contain_ceilometer_config('service_credentials/region_name').with_value('<SERVICE DEFAULT>')

2
spec/unit/type/ceilometer_config_spec.rb
View File

@ -51,7 +51,7 @@ describe 'Puppet::Type.type(:ceilometer_config)' do
}.to raise_error(Puppet::Error, /Invalid value/) }.to raise_error(Puppet::Error, /Invalid value/)
end end
it 'should autorequire the pachage that install the file' do it 'should autorequire the package that install the file' do
catalog = Puppet::Resource::Catalog.new catalog = Puppet::Resource::Catalog.new
anchor = Puppet::Type.type(:anchor).new(:name => 'ceilometer::install::end') anchor = Puppet::Type.type(:anchor).new(:name => 'ceilometer::install::end')
catalog.add_resource anchor, @ceilometer_config catalog.add_resource anchor, @ceilometer_config