openstack/puppet-ceilometer
Code Issues Proposed changes

Correct cafile directive for service_credentials

Browse Source 
Running with my own ROOT CA, it appears that the correct directive
is cafile, and not ca_file. Changing for the correct option made
certificate validation work for me, when it didn't previously.

Change-Id: Iff7575c1c0269788a908ff9db258a76d21f2da1b
This commit is contained in:
Thomas Goirand 2019-03-10 21:53:42 +01:00
parent 76ad8f6dbc
commit 9508fe1b5b
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/agent/auth.pp
View File

@ -66,9 +66,9 @@ class ceilometer::agent::auth (
include ::ceilometer::deps
if ! $auth_cacert {
ceilometer_config { 'service_credentials/ca_file': ensure => absent }
ceilometer_config { 'service_credentials/cafile': ensure => absent }
} else {
ceilometer_config { 'service_credentials/ca_file': value => $auth_cacert }
ceilometer_config { 'service_credentials/cafile': value => $auth_cacert }
}
ceilometer_config {

4
spec/classes/ceilometer_agent_auth_spec.rb
View File

@ -24,7 +24,7 @@ describe 'ceilometer::agent::auth' do
is_expected.to contain_ceilometer_config('service_credentials/password').with_value('password')
is_expected.to contain_ceilometer_config('service_credentials/password').with_value(params[:auth_password]).with_secret(true)
is_expected.to contain_ceilometer_config('service_credentials/project_name').with_value('services')
is_expected.to contain_ceilometer_config('service_credentials/ca_file').with(:ensure => 'absent')
is_expected.to contain_ceilometer_config('service_credentials/cafile').with(:ensure => 'absent')
is_expected.to contain_ceilometer_config('service_credentials/user_domain_name').with_value('Default')
is_expected.to contain_ceilometer_config('service_credentials/project_domain_name').with_value('Default')
is_expected.to contain_ceilometer_config('service_credentials/auth_type').with_value('password')
@ -40,7 +40,7 @@ describe 'ceilometer::agent::auth' do
:auth_project_domain_name => 'MyProjDomain',
)
end
it { is_expected.to contain_ceilometer_config('service_credentials/ca_file').with_value(params[:auth_cacert]) }
it { is_expected.to contain_ceilometer_config('service_credentials/cafile').with_value(params[:auth_cacert]) }
it { is_expected.to contain_ceilometer_config('service_credentials/interface').with_value(params[:auth_endpoint_type]) }
it { is_expected.to contain_ceilometer_config('service_credentials/user_domain_name').with_value(params[:auth_user_domain_name]) }
it { is_expected.to contain_ceilometer_config('service_credentials/project_domain_name').with_value(params[:auth_project_domain_name]) }