openstack/puppet-ceilometer
Code Issues Proposed changes

fix filter_project param values

Browse Source 
Current examples and tests make it look like
filter_project param is a boolean, which its not,
Its a string instead.

Change-Id: If5dbb0b1edd122a76dcc10d75f67d8f3a3fd0a7b
This commit is contained in:
Pradeep Kilambi 2016-02-17 14:48:40 -05:00 committed by Emilien Macchi
parent 5886f0ad44
commit 9ac7d218d5
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
examples/ceilometer_with_gnocchi.pp
View File

@ -33,7 +33,7 @@ class { '::ceilometer::collector':
}
class { '::ceilometer::dispatcher::gnocchi':
filter_service_activity => false,
filter_project => true,
filter_project => 'gnocchi_swift',
url => 'https://gnocchi:8041',
archive_policy => 'high',
resources_definition_file => 'gnocchi.yaml',

4
spec/classes/ceilometer_dispatcher_gnocchi_spec.rb
View File

@ -22,13 +22,13 @@ describe 'ceilometer::dispatcher::gnocchi' do
context 'when overriding parameters' do
before do
params.merge!(:filter_service_activity => false,
:filter_project => true,
:filter_project => 'gnocchi_swift',
:url => 'http://foo',
:archive_policy => 'high',
:resources_definition_file => 'foo')
end
it { is_expected.to contain_ceilometer_config('dispatcher_gnocchi/filter_service_activity').with_value('false') }
it { is_expected.to contain_ceilometer_config('dispatcher_gnocchi/filter_project').with_value('true') }
it { is_expected.to contain_ceilometer_config('dispatcher_gnocchi/filter_project').with_value('gnocchi_swift') }
it { is_expected.to contain_ceilometer_config('dispatcher_gnocchi/url').with_value('http://foo') }
it { is_expected.to contain_ceilometer_config('dispatcher_gnocchi/archive_policy').with_value('high') }
it { is_expected.to contain_ceilometer_config('dispatcher_gnocchi/resources_definition_file').with_value('foo') }