openstack
/
puppet-ceilometer
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Shi Yan replied on the change"}
Attention: {"person_ident":"Gerrit User 26721 \u003c26721@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Shi Yan replied on the change"}
This commit is contained in:
Gerrit User 26721 2022-05-05 23:18:28 +00:00 committed by Gerrit Code Review
parent cb5a9a6d4a
commit b0108f1584
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7
View File

@ -16,6 +16,24 @@
"message": "The ceilometer user should be created by ceilometer-common package. The current resource definition is used to add the ceilometer user to nova/libvirt group but we do not intend to override the default package user. I\u0027m not sure how much beneficial to let users to override uid/gid.",
"revId": "5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "acbe1e09_6b5e4639",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 26721
},
"writtenOn": "2022-05-05T23:18:28Z",
"side": 1,
"message": "yeah the benefit is more about the ceilometer container deployment. Like for kolla container, the ceilometer uid/gid will by default use different value: 42405. Have the ability to override them will make container deployment easier. So how do you think of it?",
"parentUuid": "dc8818ee_f3d77a84",
"revId": "5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}