openstack
/
puppet-ceilometer
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Takashi Kajinami replied on the change"}
Attention: {"person_ident":"Gerrit User 26721 \u003c26721@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Takashi Kajinami replied on the change"}
This commit is contained in:
Gerrit User 9816 2022-05-14 16:12:55 +00:00 committed by Gerrit Code Review
parent d47c3a4485
commit b8eb2d6b4a
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7
View File

@ -122,6 +122,24 @@
"parentUuid": "3e4f3062_2c383b6c",
"revId": "5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "05c6d1ef_234c20c7",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 9816
},
"writtenOn": "2022-05-14T16:12:55Z",
"side": 1,
"message": "The intention of the current user/group resources is to add the ceilometer user to the required groups. As in the current support scope of puppet, we expect the user/group are created by packages, exposing more interface to allow complicated user/group declaration is not desired, IMO.\n\nAlso, currently, these user/group resources are triggred after package installation. Thus the ceilometer user/group are created first with the specific uid/gid defined in package manifests during package installation, and then uid/gid are modified by the resource. This would leave the files provided by packages kept with old uid/gid. This sounds like problematic for your case, doesn\u0027t it ?\n\nIf you intend to use your own uid/gid then you should create system users/groups with desired ids first and then install packages so that package installation picks up the existing ids. The dependency required for that (create users BEFORE package installation) would conflict with what we need when we use the users created by packages.\n\nIMO the right approach is to add a knob to disable user/group management so that you can create users/groups as you want in external manifests or external tooling.\n\nSee https://review.opendev.org/c/openstack/puppet-ceilometer/+/841814 .",
"parentUuid": "1e2ab5cd_9d83ade7",
"revId": "5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}