openstack
/
puppet-ceilometer
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Shi Yan replied on the change"}
Attention: {"person_ident":"Gerrit User 26721 \u003c26721@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Shi Yan replied on the change"}
This commit is contained in:
Gerrit User 26721 2022-05-15 13:21:42 +00:00 committed by Gerrit Code Review
parent b8eb2d6b4a
commit c1a39248d1
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7
View File

@ -140,6 +140,24 @@
"parentUuid": "1e2ab5cd_9d83ade7",
"revId": "5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "001460e1_af30de2e",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 26721
},
"writtenOn": "2022-05-15T13:21:42Z",
"side": 1,
"message": "Thanks a lot Takashi for your detailed comments. Yeah, I agree with you that it may be better for me to create the user/groups in external manifests and adding a knob to enable/disable user/group management will be a reasonable solution. I will abandon my previous changes including this one, and will follow up your new refactor change instead. Thanks again!",
"parentUuid": "05c6d1ef_234c20c7",
"revId": "5abe96e9cbc1a3a9e517e9f8acf4d7533ab576a7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}