openstack
/
puppet-ceilometer
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: I would prefer that you didn't merge this

(2 inline comments)



Patch-set: 1
Label: Code-Review=-1
This commit is contained in:
Gerrit User 7156 2013-09-10 05:11:30 +00:00 committed by Gerrit Code Review
parent 7d856d0a5a
commit d246a52bc1
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
11393984a10587bba7a640d721ac4d9f86f712e7 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "AAAASn//My4\u003d",
"filename": "manifests/agent/auth.pp",
"patchSetId": 1
},
"lineNbr": 36,
"author": {
"id": 7156
},
"writtenOn": "2013-09-10T05:11:30Z",
"side": 1,
"message": "I would like no default password to be provided. I know a default password was provided before the change but I think it\u0027s a good time to remove it. ceilometer::keystone::auth has no default password so I don\u0027t expect some sort of backward compatibility to be broken in that aspect.",
"revId": "11393984a10587bba7a640d721ac4d9f86f712e7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAASn//Myw\u003d",
"filename": "manifests/agent/auth.pp",
"patchSetId": 1
},
"lineNbr": 40,
"author": {
"id": 7156
},
"writtenOn": "2013-09-10T05:11:30Z",
"side": 1,
"message": "The inheritance should be removed. It was only required by ceilometer::agent::compute to override some properties of User[\u0027ceilometer\u0027].",
"revId": "11393984a10587bba7a640d721ac4d9f86f712e7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}