openstack
/
puppet-ceilometer
Code Issues Proposed changes

[hardware] readonly_user_password should be secret 

... because the parameter accepts a password string.

Change-Id: I362b09f60c22d615ed13c79bbc25f27f3b73feb5
This commit is contained in:
Takashi Kajinami 2021-09-23 22:37:02 +09:00
parent 090c67725b
commit d987257e4e
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/init.pp
View File

@ -395,7 +395,7 @@ will be removed in a future release.')
'DEFAULT/host' : value => $host;
'publisher/telemetry_secret' : value => $telemetry_secret, secret => true;
'hardware/readonly_user_name' : value => $snmpd_readonly_username;
'hardware/readonly_user_password' : value => $snmpd_readonly_user_password;
'hardware/readonly_user_password' : value => $snmpd_readonly_user_password, secret => true;
}
oslo::messaging::notifications { 'ceilometer_config':

2
spec/classes/ceilometer_init_spec.rb
View File

@ -119,7 +119,7 @@ describe 'ceilometer' do
it 'configures snmpd auth' do
is_expected.to contain_ceilometer_config('hardware/readonly_user_name').with_value('<SERVICE DEFAULT>')
is_expected.to contain_ceilometer_config('hardware/readonly_user_password').with_value('<SERVICE DEFAULT>')
is_expected.to contain_ceilometer_config('hardware/readonly_user_password').with_value('<SERVICE DEFAULT>').with_secret(true)
end
it 'configures cache backend' do