openstack/puppet-ceilometer
Code Issues Proposed changes

Expose snmpd auth params

Browse Source 
Change-Id: I55ac06e1a561d29d7e1c928a1684989c9654b95d
This commit is contained in:
Pradeep Kilambi 2017-05-03 12:23:15 -04:00
parent 43a3bc2c21
commit e016a4bb23
2 changed files with 17 additions and 0 deletions
manifests
init.pp
spec/classes
ceilometer_init_spec.rb

12
manifests/init.pp

@ -206,6 +206,14 @@
# (Optional) Password for message broker authentication
# Defaults to $::os_service_default.
#
# [*snmpd_readonly_username*]
# (Optional) User name for snmpd authentication
# Defaults to $::os_service_default.
#
# [*snmpd_readonly_user_password*]
# (Optional) Password for snmpd authentication
# Defaults to $::os_service_default.
#
# [*purge_config*]
# (optional) Whether to set only the specified config options
# in the ceilometer config.
@ -291,6 +299,8 @@ class ceilometer(
$amqp_sasl_config_name = $::os_service_default,
$amqp_username = $::os_service_default,
$amqp_password = $::os_service_default,
$snmpd_readonly_username = $::os_service_default,
$snmpd_readonly_user_password = $::os_service_default,
$purge_config = false,
# DEPRECATED PARAMETERS
$alarm_history_time_to_live = undef,
@ -408,6 +418,8 @@ deprecated. Please use ceilometer::default_transport_url instead.")
'publisher/telemetry_secret' : value => $telemetry_secret_real, secret => true;
'database/event_time_to_live' : value => $event_time_to_live;
'database/metering_time_to_live' : value => $metering_time_to_live;
'hardware/readonly_user_name' : value => $snmpd_readonly_username;
'hardware/readonly_user_password' : value => $snmpd_readonly_user_password;
}
oslo::messaging::notifications { 'ceilometer_config':

5
spec/classes/ceilometer_init_spec.rb

@ -134,6 +134,11 @@ describe 'ceilometer' do
is_expected.to contain_ceilometer_config('oslo_messaging_notifications/transport_url').with_value('<SERVICE DEFAULT>')
end
it 'configures snmpd auth' do
is_expected.to contain_ceilometer_config('hardware/readonly_user_name').with_value('<SERVICE DEFAULT>')
is_expected.to contain_ceilometer_config('hardware/readonly_user_password').with_value('<SERVICE DEFAULT>')
end
context 'with rabbitmq durable queues configured' do
before { params.merge!( :amqp_durable_queues => true ) }
it_configures 'rabbit with durable queues'