openstack/puppet-ceph
Code Issues Proposed changes

Set lowercase for ceph_config values

Browse Source 
Capitalized values of True and False are conflicting with systemd
scripts

This commit set all values to lowercase

Fixes: Bug #1697476

Change-Id: Ibd01a7a850e7593fabd676b8b0c0af2b77101a2a
This commit is contained in:
Guilherme Maluf 2017-06-12 14:49:49 -03:00
parent 55ae425b19
commit 28c4efee3d
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/puppet/type/ceph_config.rb
View File

@ -42,7 +42,7 @@ Puppet::Type.newtype(:ceph_config) do
desc 'The value of the setting to be defined.' desc 'The value of the setting to be defined.'
munge do |value| munge do |value|
value = value.to_s.strip value = value.to_s.strip
value.capitalize! if value =~ /^(true|false)$/i value.downcase! if value =~ /^(true|false)$/i
value value
end end
end end

8
spec/unit/type/ceph_config_spec.rb
View File

@ -29,13 +29,13 @@ describe 'Puppet::Type.type(:ceph_config)' do
expect(@ceph_config[:value]).to eq('max') expect(@ceph_config[:value]).to eq('max')
end end
it 'should convert true to True' do it 'should convert true to true' do
@ceph_config[:value] = 'tRuE' @ceph_config[:value] = 'tRuE'
expect(@ceph_config[:value]).to eq('True') expect(@ceph_config[:value]).to eq('true')
end end
it 'should convert false to False' do it 'should convert false to false' do
@ceph_config[:value] = 'fAlSe' @ceph_config[:value] = 'fAlSe'
expect(@ceph_config[:value]).to eq('False') expect(@ceph_config[:value]).to eq('false')
end end
end end