Merge "Do not define service resource when service management is disabled"

manifests/api.pp

@@ -184,39 +184,37 @@ Use cinder::nova::region_name instead')
     include cinder::db::sync
   }
 
-  if $enabled {
+  if $manage_service {
-    if $manage_service {
+    if $enabled {
       $ensure = 'running'
-    }
+    } else {
-  } else {
-    if $manage_service {
       $ensure = 'stopped'
     }
-  }
 
-  if $service_name == $::cinder::params::api_service {
+    if $service_name == $::cinder::params::api_service {
-    service { 'cinder-api':
+      service { 'cinder-api':
-      ensure    => $ensure,
+        ensure    => $ensure,
-      name      => $::cinder::params::api_service,
+        name      => $::cinder::params::api_service,
-      enable    => $enabled,
+        enable    => $enabled,
-      hasstatus => true,
+        hasstatus => true,
-      tag       => 'cinder-service',
+        tag       => 'cinder-service',
-    }
+      }
 
-  } elsif $service_name == 'httpd' {
+    } elsif $service_name == 'httpd' {
-    service { 'cinder-api':
+      service { 'cinder-api':
-      ensure => 'stopped',
+        ensure => 'stopped',
-      name   => $::cinder::params::api_service,
+        name   => $::cinder::params::api_service,
-      enable => false,
+        enable => false,
-      tag    => ['cinder-service'],
+        tag    => ['cinder-service'],
-    }
+      }
-    Service <| title == 'httpd' |> { tag +> 'cinder-service' }
+      Service <| title == 'httpd' |> { tag +> 'cinder-service' }
 
-    # we need to make sure cinder-api/eventlet is stopped before trying to start apache
+      # we need to make sure cinder-api/eventlet is stopped before trying to start apache
-    Service['cinder-api'] -> Service[$service_name]
+      Service['cinder-api'] -> Service[$service_name]
-  } else {
+    } else {
-    fail("Invalid service_name. Either cinder-api/openstack-cinder-api for \
+      fail("Invalid service_name. Either cinder-api/openstack-cinder-api for \
 running as a standalone service, or httpd for being run by a httpd server")
+    }
   }
 
   cinder_config {

manifests/backup.pp

@@ -88,14 +88,14 @@ class cinder::backup (
     } else {
       $ensure = 'stopped'
     }
-  }
 
-  service { 'cinder-backup':
+    service { 'cinder-backup':
-    ensure    => $ensure,
+      ensure    => $ensure,
-    name      => $::cinder::params::backup_service,
+      name      => $::cinder::params::backup_service,
-    enable    => $enabled,
+      enable    => $enabled,
-    hasstatus => true,
+      hasstatus => true,
-    tag       => 'cinder-service',
+      tag       => 'cinder-service',
+    }
   }
 
   cinder_config {

manifests/scheduler.pp

@@ -50,13 +50,13 @@ class cinder::scheduler (
     } else {
       $ensure = 'stopped'
     }
-  }
 
-  service { 'cinder-scheduler':
+    service { 'cinder-scheduler':
-    ensure    => $ensure,
+      ensure    => $ensure,
-    name      => $::cinder::params::scheduler_service,
+      name      => $::cinder::params::scheduler_service,
-    enable    => $enabled,
+      enable    => $enabled,
-    hasstatus => true,
+      hasstatus => true,
-    tag       => 'cinder-service',
+      tag       => 'cinder-service',
+    }
   }
 }

manifests/volume.pp

@@ -92,14 +92,14 @@ class cinder::volume (
     } else {
       $ensure = 'stopped'
     }
-  }
 
-  service { 'cinder-volume':
+    service { 'cinder-volume':
-    ensure    => $ensure,
+      ensure    => $ensure,
-    name      => $::cinder::params::volume_service,
+      name      => $::cinder::params::volume_service,
-    enable    => $enabled,
+      enable    => $enabled,
-    hasstatus => true,
+      hasstatus => true,
-    tag       => 'cinder-service',
+      tag       => 'cinder-service',
+    }
   }
 
   cinder_config {

spec/classes/cinder_api_spec.rb

@@ -101,7 +101,7 @@ describe 'cinder::api' do
         req_params.merge({'manage_service' => false})
       end
       it 'should not change the state of the service' do
-        is_expected.to contain_service('cinder-api').without_ensure
+        is_expected.to_not contain_service('cinder-api')
       end
       it 'includes cinder::db::sync' do
         is_expected.to contain_class('cinder::db::sync')

spec/classes/cinder_backup_spec.rb

@@ -91,13 +91,8 @@ describe 'cinder::backup' do
       before :each do
         params.merge!(:manage_service => false)
       end
-      it 'should not change the state of the service' do
+      it 'should not configure the service' do
-        is_expected.to contain_service('cinder-backup').with(
+        is_expected.to_not contain_service('cinder-backup')
-          :ensure    => nil,
-          :name      => platform_params[:backup_service],
-          :hasstatus => true,
-          :tag       => 'cinder-service',
-        )
       end
     end
 

spec/classes/cinder_scheduler_spec.rb

@@ -40,7 +40,7 @@ describe 'cinder::scheduler' do
         }
       end
 
-      it { is_expected.to contain_service('cinder-scheduler').without_ensure }
+      it { is_expected.to_not contain_service('cinder-scheduler') }
     end
   end
 

spec/classes/cinder_volume_spec.rb

@@ -32,7 +32,7 @@ describe 'cinder::volume' do
         }
       end
 
-      it { is_expected.to contain_service('cinder-volume').without_ensure }
+      it { is_expected.to_not contain_service('cinder-volume') }
     end
 
     context 'with parameters overridden' do