openstack/puppet-cinder
Code Issues Proposed changes

Do not validate database_connection format

Browse Source 
Currently we validate database_connection in 2 layers, each puppet
modules and puppet-oslo, however this makes it difficult to maintain
validation pattern because we always need to fix both.
This patch removes the validation from each puppet modules so that
we need to maitain only one place, puppet-oslo to update validation
logic.

Change-Id: I84312d013089696c54f8ec7e64dabdab95b07f2a
This commit is contained in:
Takashi Kajinami
2020-08-31 00:00:27 +09:00
parent 8ea1713484
commit 46756a8304
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
manifests/db.pp
View File

@ -72,9 +72,6 @@ class cinder::db (
$database_retry_interval_real = pick($::cinder::database_retry_interval,$database_retry_interval)
$database_max_overflow_real = pick($::cinder::database_max_overflow,$database_max_overflow)
validate_legacy(Oslo::Dbconn, 'validate_re', $database_connection_real,
['^(sqlite|mysql(\+pymysql)?|postgresql):\/\/(\S+:\S+@\S+\/\S+)?'])
oslo::db { 'cinder_config':
db_max_retries => $database_db_max_retries,
connection => $database_connection_real,