openstack
/
puppet-cinder
Code Issues Proposed changes

Simplify handling of scheduler_default_filters 

Change-Id: Ie6a860c5c12a0c61965a399e03ea1ede1af8bf64
This commit is contained in:
Takashi Kajinami 2021-11-15 08:46:02 +09:00
parent 930c60903b
commit 803abc3814
2 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
manifests/scheduler/filter.pp
View File

@ -14,14 +14,7 @@ class cinder::scheduler::filter (
include cinder::deps
if (!is_service_default($scheduler_default_filters)) {
cinder_config {
'DEFAULT/scheduler_default_filters': value => join(any2array($scheduler_default_filters),',')
}
} else {
cinder_config {
'DEFAULT/scheduler_default_filters': ensure => absent
}
cinder_config {
'DEFAULT/scheduler_default_filters': value => join(any2array($scheduler_default_filters),',')
}
}

2
spec/classes/cinder_scheduler_filter_spec.rb
View File

@ -18,7 +18,7 @@ describe 'cinder::scheduler::filter' do
end
it 'contains default values' do
is_expected.to contain_cinder_config('DEFAULT/scheduler_default_filters').with_ensure('absent')
is_expected.to contain_cinder_config('DEFAULT/scheduler_default_filters').with_value(p[:scheduler_default_filters])
end
context 'configure filters with array' do