openstack
/
puppet-cinder
Code Issues Proposed changes

Fix missing inclusion of cinder::params 

This fixes the missing inclusion of cinder::params, to ensure
the subsequent reference works properly.

Change-Id: Idca647a1c149d93f3c477ac448ddc69ac5bbb2b1
This commit is contained in:
Takashi Kajinami 2023-06-23 12:19:22 +09:00
parent 47e7587063
commit 8d00e748ef
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
manifests/backend/dellemc_powermax.pp
View File

@ -67,6 +67,7 @@ define cinder::backend::dellemc_powermax (
) {
include cinder::deps
include cinder::params
if $powermax_storage_protocol == 'iSCSI' {
$volume_driver = 'cinder.volume.drivers.dell_emc.powermax.iscsi.PowerMaxISCSIDriver'

19
spec/defines/cinder_backend_dellemc_powermax_spec.rb
View File

@ -30,6 +30,12 @@ describe 'cinder::backend::dellemc_powermax' do
is_expected.to contain_cinder_config("#{title}/powermax_srp").with_value('SRP_1')
is_expected.to contain_cinder_config("#{title}/powermax_port_groups").with_value('[OS-ISCSI-PG]')
is_expected.to contain_cinder_config("#{title}/backend_availability_zone").with_value('<SERVICE DEFAULT>')
is_expected.to contain_package('pywbem').with(
:ensure => 'installed',
:name => platform_params[:pywbem_package_name],
:tag => 'cinder-support-package',
)
end
end
@ -95,6 +101,19 @@ describe 'cinder::backend::dellemc_powermax' do
facts.merge!(OSDefaults.get_facts())
end
let :platform_params do
case facts[:os]['family']
when 'Debian'
{
:pywbem_package_name => 'python-pywbem'
}
when 'RedHat'
{
:pywbem_package_name => 'pywbem'
}
end
end
it_behaves_like 'cinder::backend::dellemc_powermax'
end
end