From f51903716fd828b3656bb0277804fe0470d9f8a9 Mon Sep 17 00:00:00 2001 From: ZhongShengping Date: Fri, 15 Feb 2019 10:03:00 +0800 Subject: [PATCH] Service_token_roles_required missing in the server config file Service_token_roles_required missing in the server config file which allows backwards compatibility to ensure that the service tokens are compared against a list of possible roles for validity. Change-Id: Ic8e5badec98f5d14e71a36d303f9a7f01962f1d3 Closes-Bug: 1778198 --- manifests/keystone/authtoken.pp | 8 ++++++++ .../service_token_roles_required-92618e63dceeb2bd.yaml | 5 +++++ spec/classes/cinder_keystone_authtoken_spec.rb | 3 +++ 3 files changed, 16 insertions(+) create mode 100644 releasenotes/notes/service_token_roles_required-92618e63dceeb2bd.yaml diff --git a/manifests/keystone/authtoken.pp b/manifests/keystone/authtoken.pp index ac750043..780b849e 100644 --- a/manifests/keystone/authtoken.pp +++ b/manifests/keystone/authtoken.pp @@ -165,6 +165,12 @@ # (in seconds). Set to -1 to disable caching completely. Integer value # Defaults to $::os_service_default. # +# [*service_token_roles_required*] +# (optional) backwards compatibility to ensure that the service tokens are +# compared against a list of possible roles for validity +# true/false +# Defaults to $::os_service_default. +# # DEPRECATED PARAMETERS # # [*check_revocations_for_cached*] @@ -218,6 +224,7 @@ class cinder::keystone::authtoken( $manage_memcache_package = false, $region_name = $::os_service_default, $token_cache_time = $::os_service_default, + $service_token_roles_required = $::os_service_default, # DEPRECATED PARAMETERS $check_revocations_for_cached = undef, $hash_algorithms = undef, @@ -270,5 +277,6 @@ class cinder::keystone::authtoken( manage_memcache_package => $manage_memcache_package, region_name => $region_name, token_cache_time => $token_cache_time, + service_token_roles_required => $service_token_roles_required, } } diff --git a/releasenotes/notes/service_token_roles_required-92618e63dceeb2bd.yaml b/releasenotes/notes/service_token_roles_required-92618e63dceeb2bd.yaml new file mode 100644 index 00000000..60a45217 --- /dev/null +++ b/releasenotes/notes/service_token_roles_required-92618e63dceeb2bd.yaml @@ -0,0 +1,5 @@ +--- +features: + - Service_token_roles_required missing in the server config file which + allows backwards compatibility to ensure that the service tokens are + compared against a list of possible roles for validity. diff --git a/spec/classes/cinder_keystone_authtoken_spec.rb b/spec/classes/cinder_keystone_authtoken_spec.rb index 9fff8068..23790997 100644 --- a/spec/classes/cinder_keystone_authtoken_spec.rb +++ b/spec/classes/cinder_keystone_authtoken_spec.rb @@ -41,6 +41,7 @@ describe 'cinder::keystone::authtoken' do is_expected.to contain_cinder_config('keystone_authtoken/memcached_servers').with_value('') is_expected.to contain_cinder_config('keystone_authtoken/region_name').with_value('') is_expected.to contain_cinder_config('keystone_authtoken/token_cache_time').with_value('') + is_expected.to contain_cinder_config('keystone_authtoken/service_token_roles_required').with_value('') end end @@ -79,6 +80,7 @@ describe 'cinder::keystone::authtoken' do :manage_memcache_package => true, :region_name => 'region2', :token_cache_time => '301', + :service_token_roles_required => false, }) end @@ -114,6 +116,7 @@ describe 'cinder::keystone::authtoken' do is_expected.to contain_cinder_config('keystone_authtoken/memcached_servers').with_value('memcached01:11211,memcached02:11211') is_expected.to contain_cinder_config('keystone_authtoken/region_name').with_value(params[:region_name]) is_expected.to contain_cinder_config('keystone_authtoken/token_cache_time').with_value(params[:token_cache_time]) + is_expected.to contain_cinder_config('keystone_authtoken/service_token_roles_required').with_value(params[:service_token_roles_required]) end it 'installs python memcache package' do