From fd66bd64465f36bc87ff17969e47c9a0b538bd16 Mon Sep 17 00:00:00 2001
From: Takashi Kajinami <kajinamit@oss.nttdata.com>
Date: Fri, 8 Mar 2024 14:50:36 +0900
Subject: [PATCH] Deprecate support for VMWare storage driver

We deprecated vmwareapi virt driver support of puppet-nova during
2023.2 cycle[1] and then removed it in 2024.2 cycle[2] based on
the driver status.

Because we don't expect any users may use VMWare storage driver without
vmwareapi virt driver, this deprecates support for VMWare storage
driver. We aim to remove it in 2024.1 cycle.

[1] 8bf7f7d2e9604e24b6226077fced4af92dacd7a5
[2] 1d0bee66fce81f1d9e40b66f280584ea28e69b45

Change-Id: I775b4ee578169d3c6dfd2087b5286ff6a84de012
---
 manifests/backend/vmdk.pp                                 | 3 +++
 manifests/vmware.pp                                       | 3 +++
 releasenotes/notes/deprecate-vmware-9628bcac0e2435e6.yaml | 8 ++++++++
 3 files changed, 14 insertions(+)
 create mode 100644 releasenotes/notes/deprecate-vmware-9628bcac0e2435e6.yaml

diff --git a/manifests/backend/vmdk.pp b/manifests/backend/vmdk.pp
index 248830d9..a3ccb5cf 100644
--- a/manifests/backend/vmdk.pp
+++ b/manifests/backend/vmdk.pp
@@ -1,5 +1,6 @@
 # == define: cinder::backend::vmdk
 #
+# DEPRECATED !!
 # Configure the VMware VMDK driver for cinder.
 #
 # === Parameters
@@ -87,6 +88,8 @@ define cinder::backend::vmdk (
 
   include cinder::deps
 
+  warning('Support for VMWare storage driver has been deprecated')
+
   cinder_config {
     "${name}/volume_backend_name":                value => $volume_backend_name;
     "${name}/backend_availability_zone":          value => $backend_availability_zone;
diff --git a/manifests/vmware.pp b/manifests/vmware.pp
index e28c5868..4c005b89 100644
--- a/manifests/vmware.pp
+++ b/manifests/vmware.pp
@@ -1,11 +1,14 @@
 # == Class: cinder::vmware
 #
+# DEPRECATED !!
 # Creates vmdk specific disk file type & clone type.
 #
 class cinder::vmware {
 
   include cinder::deps
 
+  warning('Support for VMWare storage driver has been deprecated')
+
   cinder_type { 'vmware-thin':
     ensure     => present,
     properties => ['vmware:vmdk_type=thin']
diff --git a/releasenotes/notes/deprecate-vmware-9628bcac0e2435e6.yaml b/releasenotes/notes/deprecate-vmware-9628bcac0e2435e6.yaml
new file mode 100644
index 00000000..1ef692bd
--- /dev/null
+++ b/releasenotes/notes/deprecate-vmware-9628bcac0e2435e6.yaml
@@ -0,0 +1,8 @@
+---
+deprecations:
+  - |
+    The following implementations have been deprecated and will be removed
+    in a future release.
+
+    - ``cinder::vmware`` class
+    - ``cinder::backend::vmdk`` defined resource type