16 Commits

Author SHA1 Message Date
Cody Herriges
46e46998d0 Remove code deprecated in liberty cycle
This commit removes all code that was related to deprecations,
  including tests put in during the liberty release cycle and
  increases the verbosity of warnings provided for code deprecated
  during this cycle (Mitaka).

Change-Id: I991654c6c0706eea31a6702703596e73080bec4e
2016-01-26 14:14:04 -08:00
Emilien Macchi
1d7643ba77 Revert "Default service_name to 'Volume Service'"
This reverts commit 9125857f423212b008a158942e9ce9c36f6aef9d.

Change-Id: I12dfd382abc6d5ec562fcc02ccfb4ee08f5ebe1c
2016-01-11 20:24:45 +00:00
Emilien Macchi
9125857f42 Default service_name to 'Volume Service'
In Liberty, we sent a warning if service_name was not set (and auth_name
was configured as the service name), with the goal to define the correct
default value during Mitaka.
This patch set the service_name parameter to 'Volume Service' by default
to match with Keystone's default catalog. Note: if you already run
OpenStack, when you'll run Puppet after this change, the old service
will still be present and you'll have to drop it manually. Though the
Cinder endpoint will be updated with the new service.

Change-Id: I3bfed1b91f99f4da5ba19d2b1f847346fa19beec
Closes-bug: #1506061
2016-01-06 17:59:04 -05:00
Emilien Macchi
dcd11019d7 unit tests: make Keystone_endpoint match service by name/type
Since a chance in puppet-keystone (1], we now match an endpoint with a
service name/type.
)
[1] http://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=0a4e06abb0f5b3f324464ff5219d2885816311ce

Closes-Bug: #1528308

Change-Id: Iaffb38d5cc4dc4022192af9216e604851ddcad2d
2015-12-22 18:05:43 +01:00
Denis Egorenko
e6bb23600d Update rspec tests for keystone
https://review.openstack.org/#/c/228744/ has been merged, we need to
drop the 'tenant' parameter to Keystone_user resource.

Change-Id: Ifa3b13eef94d46c4008f7cb0707169f581ddf153
2015-10-21 16:48:48 +03:00
Yanis Guenane
18f2db7a1d Specify a dedicated keystone user for cinderv2
This commit aims to give the user the flexibility to be able to create a
specific user for cinderv2 if one wants to.

Until now the value was hardcoded to false preventing a deployer from
creating this user if necessary.

Change-Id: I3b17a4f8c5a8d7ca1a91e989ba7f8bd7cfecc026
2015-10-16 13:17:40 +00:00
Gael Chamoulaud
e25dc7eba1 Fix rspec 3.x syntax
- Convert 'should' keyword to 'is_expected.to'

Change-Id: I6183a18223407c92350f8452c48fcbd1e16c5559
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
2015-07-20 15:47:11 +02:00
Mathieu Gagné
b59f035e11 Introduce public_url, internal_url and admin_url
This change deprecates the following parameters:
- port (replaced by public/internal/admin_url)
- public_protocol (replaced by public_url)
- internal_protocol (replaced by internal_url)
- admin_protocol (replaced by admin_url)
- public_address (replaced by public_url)
- internal_address (replaced by internal_url)
- admin_address (replaced by admin_url)

Add deprecation warnings if any of those values are provided
while maintaining full backward compatibility.

Closes-bug: #1274979
Change-Id: I4b97b004d7d302163f5a1c18cc21d3ff728cb227
2015-06-05 13:22:22 -04:00
Sebastien Badia
4a3bfbce84 Fix spec tests for RSpec 3.x and Puppet 4.x
Remove value testing (we only check the key here), the value is nil or undef
and fix resource array, according[1].

[1]https://github.com/puppetlabs/puppet/blob/3.7.5/lib/puppet/resource.rb#L446-L453

Closes-bug: #1447620
Change-Id: I274089772b07db500b2e571588b4fb5285c131b0
2015-04-28 03:08:49 +02:00
Sebastien Badia
4224fdd12e spec: updates for rspec-puppet 2.x and rspec 3.x
This patch aim to update our specs test in order to work with the

rspec-puppet release 2.0.0, in the mean time, we update rspec syntax
in order to be prepared for rspec 3.x move.

In details:

  * Use shared_examples "a Puppet::Error" for puppet::error tests
  * Convert 'should' keyword to 'is_expected.to' (prepare rspec 3.x)
  * Fix spec tests for rspec-puppet 2.0.0
  * Upgrade and pin rspec-puppet from 1.0.1 to 2.0.0
  * Clean Gemfile (remove over-specificication of runtime deps of puppetlabs_spec_helper)

Change-Id: Id5b428fb518f40cf92cd27078d36f19b6d60226b
Card: https://trello.com/c/eHXc1Ryd/4-investigate-the-necessary-change-to-be-rspec-puppet-2-0-0-compliant
2015-03-11 17:58:49 +01:00
Rico Lin
e783087933 Adds ability to override service name for service catalog
Instead of forcing the name of the service in the service catalog to
match auth_name, this allows the ability to explicitly set the service
name, spearately from auth_name.
If service_name is not specified, it's value defaults to the value
of auth_name (which maintains the current behavior.)

Change-Id: Ia3d00186a422a16ec6bd7b65008ec56abc1e8f67
Closes-bug: #1359755
2015-02-10 09:59:25 +08:00
Risto Laurikainen
da2f5a125c Make user creation optional when creating service.
In some cases it is useful to be able to just configure
the service in Keystone and not the service user. This
is the case when e.g. a read only LDAP backend is used.
Added parameters configure_user and configure_user_role
(default to true).

Change-Id: I021976f1eafa881755c0abbe1f6ba1b546dee111
Closes-Bug: 1360232
2014-09-11 12:21:14 +03:00
Emilien Macchi
9b33d7e1a7 v2 endpoints: internal & admin protocols support
Allow to change HTTP as default endpoint protocol for both admin &
internal.

Change-Id: I6c724229f35464be681fefb067abe44a86ce84b3
Signed-off-by: Emilien Macchi <emilien.macchi@enovance.com>
2014-06-24 11:48:12 +02:00
Emilien Macchi
6dbafb7a8f Add Cinder v2 Keystone endpoint support
In Icehouse release, official API supported is v2 but Nova does not
support it at this time.

For now, we keep v1 endpoint for backward compatibility and let the
operator create a v2 endpoint.

Change-Id: I27264dff683c47560351235c8e398afe7c8df2f0
Signed-off-by: Emilien Macchi <emilien.macchi@enovance.com>
2014-05-06 21:38:12 +02:00
Benedikt Trefzer
414c7ecec6 add parameter for endpoint protocols
This gives the ability to specify https endpoint for
internal and/or admin endpoints.

Change-Id: I9cc1525449ffd9b1439e6e5fcbf6731b8a7ee260
backport: havana
2014-03-10 13:56:22 +01:00
Dan Bode
ec77314554 Add basic spec tests
This commit adds basic test coverage. It is no
100% coverage, but its a great start.
2012-10-29 12:58:03 -07:00