This patch changes the default worker count from ::processorcount to the
new ::os_workers fact. ::os_workers is based on the number of processors
(currently cpu/4) but is capped at a maximum of 8 worker processors.
This is a much more reasonable default in general and prevents excessive
resource consumption on systems with a large number of CPUs.
Change-Id: I159bb64d024c2207526c73212d68230d8362164c
This commit partially reverts original commit.
use_syslog option is not deprecated and still actual.
This reverts commit I76fd567f53ef8f0f4d351d52043e3ba2fea6f02f
Change-Id: I422bc5ce8560d805a93e2a23c5a2f0ffa9870b6b
Option "verbose" from group "DEFAULT" is deprecated for removal.
The parameter has no effect.
-Deprecated verbose for logging and init
-Remove verbose in examples and README
-Remove verbose from tests.
If this option is not set explicitly, there is no such warning.
Change-Id: I573b2480195df2e7b390245d418ec5535c8e2cdd
This change updates the test that currently do Debian/RedHat sets of
tests to use on_supported_os from rspec-puppet-facts. This improves the
over all coverage with the specific CentOS, Debian, RedHat and Ubuntu
flavors of facts.
Change-Id: Ic7b12cd8972bbde0574806acb2d680f14f1c267f
With the os_service_default updates, we introduced a regression since
the default log_dir needs to be specified if we want logs. Previously it
was defined as /var/log/cinder so this change adds it back in.
Change-Id: I51c3cb7be8c62cba3b9dbca292a7bb73d9a658b2
Prior to this change, we were incorrectly using merge! on the
@default_facts. This would eventually lead to weird testing issues if
@default_facts was ever reused within a test run. merge!(...) will
update the @default_facts variable and we want to use merge(...) so that
we are not updating the @default_facts variable.
Change-Id: I55b518ee4af1a76ff5fc0e071410ccee5e4dfb34
Currently logging configuration is splitted in two distinct classes, the
init.pp and the logging.pp classes.
This review aims to centralize all logging related parameters in a
single class, the logging.pp one.
The impacted parameters are :
* use_syslog
* use_stderr
* log_facility
* verbose
* debug
* log_dir
This change remains backward compatible with what is currently in place.
Change-Id: Id6ef37e6debbdcad0727359f974cf1575a5509f0
This change switches the cinder module to use the os_service_default
fact for configuration options that default to '<SERVICE DEFAULT>'.
Change-Id: I8c28f02794fdc7034a85eab80a66a98f664380ea
Depends-On: Ieeb92b4e7fbb556a8d32682fb24284091227c991
Few weeks ago, a patchset[1] that aims to treat the value '<SERVICE
DEFAULT>' of a parameter as if ensure => absent has been merged.
The final objective of this patch was to make our manifests lighter to
read and write by avoiding the pattern
if $var { value => $var } else { ensure => absent }
This commit brings this feature to the puppet-cinder module and remains
backward compatible with what was in place before.
This commit switches a part of the module, another commit will switch the
other part (init.pp/paste).
The split in reviews aims to offer :
* easier readability on this one
* the other review might needs other change as well - not a drop in
replacement, contrary to this one so it is simpler to split it.
[1]
b554d30aaf
Change-Id: I005096625a9ea7d069893e4a3d64aa31e074378e
This patch aim to update our specs test in order to work with the
rspec-puppet release 2.0.0, in the mean time, we update rspec syntax
in order to be prepared for rspec 3.x move.
In details:
* Use shared_examples "a Puppet::Error" for puppet::error tests
* Convert 'should' keyword to 'is_expected.to' (prepare rspec 3.x)
* Fix spec tests for rspec-puppet 2.0.0
* Upgrade and pin rspec-puppet from 1.0.1 to 2.0.0
* Clean Gemfile (remove over-specificication of runtime deps of puppetlabs_spec_helper)
Change-Id: Id5b428fb518f40cf92cd27078d36f19b6d60226b
Card: https://trello.com/c/eHXc1Ryd/4-investigate-the-necessary-change-to-be-rspec-puppet-2-0-0-compliant
There is a range of extended logging options in Openstack services that use
openstack.common.logger (Ceilometer, Cinder, Heat, Keystone, Nova). Adding
cinder::logging to support them. This change is identical to
<https://review.openstack.org/#/c/113560/> but it applies to puppet-cinder
instead of puppet-ceilometer.
No blueprint/spec, as discussed in the IRC meeting on 08-11-2014.
Change-Id: Id1d4380157e681da9ada2e2647ab285ce3cc40ad
