openstack/puppet-cloudkitty
Code Issues Proposed changes

Fix common options position in params.pp

Browse Source 
These parameters are common for both systems,
they could be moved out from 'case'.

Change-Id: Ib9cb307582ff30f92292daf6bf934fa67ac88e5d
This commit is contained in:
ZhongShengping
2016-11-08 09:45:09 +08:00
parent d19257b298
commit 2a664ba86c
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
manifests/params.pp
View File

@@ -3,6 +3,11 @@
# Parameters for puppet-cloudkitty # Parameters for puppet-cloudkitty
# #
class cloudkitty::params { class cloudkitty::params {
include ::openstacklib::defaults
$client_package_name = 'python-cloudkittyclient'
$api_service_name = 'cloudkitty-api'
$processor_service_name = 'cloudkitty-processor'
case $::osfamily { case $::osfamily {
'RedHat': { 'RedHat': {
@@ -11,10 +16,6 @@ class cloudkitty::params {
$processor_package_name = 'openstack-cloudkitty-processor' $processor_package_name = 'openstack-cloudkitty-processor'
$ui_package_name = 'openstack-cloudkitty-ui' $ui_package_name = 'openstack-cloudkitty-ui'
$common_package_name = 'openstack-cloudkitty-common' $common_package_name = 'openstack-cloudkitty-common'
$client_package_name = 'python-cloudkittyclient'
# service names
$api_service_name = 'cloudkitty-api'
$processor_service_name = 'cloudkitty-processor'
} }
'Debian': { 'Debian': {
# package names # package names
@@ -22,10 +23,6 @@ class cloudkitty::params {
$processor_package_name = 'cloudkitty-processor' $processor_package_name = 'cloudkitty-processor'
$ui_package_name = 'cloudkitty-dashboard' $ui_package_name = 'cloudkitty-dashboard'
$common_package_name = 'cloudkitty-common' $common_package_name = 'cloudkitty-common'
$client_package_name = 'python-cloudkittyclient'
# service names
$api_service_name = 'cloudkitty-api'
$processor_service_name = 'cloudkitty-processor'
} }
default: { default: {
fail("Unsupported osfamily: ${::osfamily} operatingsystem") fail("Unsupported osfamily: ${::osfamily} operatingsystem")