openstack/puppet-designate
Code Issues Proposed changes

Remove POSIX users, groups and files managed by packaging

Browse Source 
Both RDO and UCA provide packaging for designate and this packaging
takes care of creating the necessary user/group/directories.

Change-Id: Ic6af7dadb94a9ce22ad924184715b729b36ed16b
Related-Bug: #1458915
This commit is contained in:
David Moreau-Simard 2016-07-05 20:52:09 -04:00
parent c55b82433d
commit 50c12167f6
5 changed files with 0 additions and 81 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
manifests/backend/bind9.pp
View File

@ -42,17 +42,4 @@ class designate::backend::bind9 (
line => 'allow-new-zones yes;',
require => Class['::designate'],
}
Class['::dns'] -> User['designate']
User<| title == 'designate' |> {
groups +> $::dns::params::group,
}
file { '/var/lib/designate':
ensure => directory,
owner => 'designate',
group => $::dns::params::group,
mode => '0750',
}
}

8
manifests/backend/powerdns.pp
View File

@ -35,13 +35,6 @@ class designate::backend::powerdns (
recurse => true,
}
file { '/var/lib/designate':
ensure => directory,
owner => 'designate',
group => 'designate',
mode => '0750',
}
designate_config {
'backend:powerdns/connection': value => $database_connection, secret => true;
'backend:powerdns/use_db_reconnect': value => $use_db_reconnect;
@ -50,5 +43,4 @@ class designate::backend::powerdns (
if $sync_db {
include ::designate::db::powerdns::sync
}
}

26
manifests/init.pp
View File

@ -184,32 +184,6 @@ class designate(
tag => ['openstack', 'designate-package'],
}
if $package_ensure != 'absent' {
Package['designate-common'] -> User['designate']
Package['designate-common'] -> Group['designate']
}
user { 'designate':
ensure => 'present',
name => 'designate',
gid => 'designate',
system => true,
before => Anchor['designate::install::end'],
}
group { 'designate':
ensure => 'present',
name => 'designate',
before => Anchor['designate::install::end'],
}
file { '/etc/designate/':
ensure => directory,
owner => 'designate',
group => 'designate',
mode => '0750',
}
resources { 'designate_config':
purge => $purge_config,
}

6
spec/classes/designate_backend_powerdns_spec.rb
View File

@ -14,12 +14,6 @@ describe 'designate::backend::powerdns' do
it 'configures designate backend powerdns with default parameters' do
is_expected.to contain_designate_config('backend:powerdns/connection').with_value('mysql://dbserver')
is_expected.to contain_designate_config('backend:powerdns/use_db_reconnect').with_value(true)
is_expected.to contain_file('/var/lib/designate').with(
'ensure' => 'directory',
'owner' => 'designate',
'group' => 'designate',
'mode' => '0750',
)
end
it 'includes designate::db::powerdns::sync' do

28
spec/classes/designate_init_spec.rb
View File

@ -115,39 +115,11 @@ describe 'designate' do
it { is_expected.to contain_class('designate::logging') }
it { is_expected.to contain_class('designate::params') }
it 'configures designate group' do
is_expected.to contain_group('designate').with(
:ensure => 'present',
:name => 'designate',
:before => 'Anchor[designate::install::end]',
)
end
it 'configures designate user' do
is_expected.to contain_user('designate').with(
:ensure => 'present',
:name => 'designate',
:gid => 'designate',
:system => true,
:before => 'Anchor[designate::install::end]',
)
end
it 'configures designate configuration folder' do
is_expected.to contain_file('/etc/designate/').with(
:ensure => 'directory',
:owner => 'designate',
:group => 'designate',
:mode => '0750'
)
end
it 'installs designate common package' do
is_expected.to contain_package('designate-common').with(
:ensure => 'installed',
:name => platform_params[:common_package_name],
:tag => ['openstack', 'designate-package'],
:before => ['User[designate]', 'Group[designate]'],
)
end