Add strict validation about boolean parameters

This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.

Change-Id: I703a2a64ce15ea6adf7cf233e635baf3ad963d31

manifests/agent.pp

@@ -50,6 +50,9 @@ class designate::agent (
 
   include designate::deps
 
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+
   warning('The agent framework has been deprecated.')
 
   designate_config {

manifests/api.pp

@@ -130,6 +130,9 @@ class designate::api (
   include designate::deps
   include designate::policy
 
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+
   # API Service
   designate_config {
     'service:api/listen'                    : value => $listen;

manifests/central.pp

@@ -76,6 +76,9 @@ class designate::central (
   include designate::deps
   include designate::db
 
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+
   designate_config {
     'service:central/managed_resource_email'     : value => $managed_resource_email;
     'service:central/managed_resource_tenant_id' : value => $managed_resource_tenant_id;

manifests/generic_service.pp

@@ -42,6 +42,9 @@ define designate::generic_service(
   include designate::deps
   include designate::params
 
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+
   $designate_title = "designate-${name}"
 
   if ($package_name) {

manifests/mdns.pp

@@ -85,6 +85,9 @@ class designate::mdns (
   include designate::deps
   include designate::db
 
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+
   designate_config {
     'service:mdns/workers'            : value => $workers;
     'service:mdns/threads'            : value => $threads;

manifests/producer.pp

@@ -42,6 +42,11 @@ class designate::producer (
   $enabled_tasks  = $facts['os_service_default'],
 ) inherits designate::params {
 
+  include designate::deps
+
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+
   designate_config {
     'service:producer/workers'       : value => $workers;
     'service:producer/threads'       : value => $threads;

manifests/sink.pp

@@ -46,6 +46,9 @@ class designate::sink (
 
   include designate::deps
 
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+
   designate::generic_service { 'sink':
     enabled        => $enabled,
     manage_service => $manage_service,

manifests/worker.pp

@@ -74,6 +74,9 @@ class designate::worker(
 
   include designate::deps
 
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+
   designate::generic_service { 'worker':
     package_ensure => $package_ensure,
     enabled        => $enabled,