openstack/puppet-designate
Code Issues Proposed changes

Expose parameter to customize [oslo_messaging_notifications] retry

Browse Source 
The parameter has been managed by puppet-oslo, but its value could not
be set via this module.

Change-Id: Ia5d586d36f85627d961b26d9374af3b1bb275b47
This commit is contained in:
Takashi Kajinami 2024-09-30 12:21:40 +09:00
parent 90bf5ed359
commit f7e4f73fde
3 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
manifests/init.pp
View File

@ -151,6 +151,11 @@
# (optional) Notification Topics # (optional) Notification Topics
# Defaults to $facts['os_service_default'] # Defaults to $facts['os_service_default']
# #
# [*notification_retry*]
# (Optional) The maximum number of attempts to re-sent a notification
# message, which failed to be delivered due to a recoverable error.
# Defaults to $facts['os_service_default'].
#
# [*purge_config*] # [*purge_config*]
# (optional) Whether to set only the specified config options # (optional) Whether to set only the specified config options
# in the designate config. # in the designate config.
@ -199,6 +204,7 @@ class designate(
$notification_driver = $facts['os_service_default'], $notification_driver = $facts['os_service_default'],
$notification_transport_url = $facts['os_service_default'], $notification_transport_url = $facts['os_service_default'],
$notification_topics = $facts['os_service_default'], $notification_topics = $facts['os_service_default'],
$notification_retry = $facts['os_service_default'],
Boolean $purge_config = false, Boolean $purge_config = false,
$amqp_durable_queues = $facts['os_service_default'], $amqp_durable_queues = $facts['os_service_default'],
$default_ttl = $facts['os_service_default'], $default_ttl = $facts['os_service_default'],
@ -250,6 +256,7 @@ class designate(
driver => $notification_driver, driver => $notification_driver,
transport_url => $notification_transport_url, transport_url => $notification_transport_url,
topics => $notification_topics, topics => $notification_topics,
retry => $notification_retry,
} }
# default setting # default setting

4
releasenotes/notes/notification-retry-33da16698e35e99d.yaml Normal file
View File

@ -0,0 +1,4 @@
---
features:
- |
The new ``designate::notification_retry`` parameter has been added.

3
spec/classes/designate_init_spec.rb
View File

@ -104,7 +104,8 @@ describe 'designate' do
is_expected.to contain_oslo__messaging__notifications('designate_config').with( is_expected.to contain_oslo__messaging__notifications('designate_config').with(
:driver => '<SERVICE DEFAULT>', :driver => '<SERVICE DEFAULT>',
:transport_url => '<SERVICE DEFAULT>', :transport_url => '<SERVICE DEFAULT>',
:topics => '<SERVICE DEFAULT>' :topics => '<SERVICE DEFAULT>',
:retry => '<SERVICE DEFAULT>',
) )
is_expected.to contain_oslo__messaging__rabbit('designate_config').with( is_expected.to contain_oslo__messaging__rabbit('designate_config').with(
:kombu_ssl_version => '<SERVICE DEFAULT>', :kombu_ssl_version => '<SERVICE DEFAULT>',