openstack
/
puppet-designate
Code Issues Proposed changes

producer: Convert enabled_tasks to comma separated list 

... because the parameter is ListOpt.

Change-Id: Ib23a9cd3586342ed69d960e43dcc2070ac1cad0d
This commit is contained in:
Takashi Kajinami 2021-07-20 13:30:12 +09:00
parent 37fde00403
commit fc113562ab
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/producer.pp
View File

@ -53,7 +53,7 @@ class designate::producer (
designate_config {
'service:producer/workers' : value => $workers;
'service:producer/threads' : value => $threads;
'service:producer/enabled_tasks' : value => $enabled_tasks;
'service:producer/enabled_tasks' : value => join(any2array($enabled_tasks), ',');
}
if $backend_url != undef {

14
spec/classes/designate_producer_spec.rb
View File

@ -35,19 +35,19 @@ describe 'designate::producer' do
end
it 'configures designate producer with default config options' do
is_expected.to contain_designate_config("service:producer/workers").with(:value => 8)
is_expected.to contain_designate_config("service:producer/threads").with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_designate_config("service:producer/enabled_tasks").with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_designate_config("service:producer/workers").with_value(8)
is_expected.to contain_designate_config("service:producer/threads").with_value('<SERVICE DEFAULT>')
is_expected.to contain_designate_config("service:producer/enabled_tasks").with_value('<SERVICE DEFAULT>')
end
end
context 'with non default parameters' do
before { params.merge!( designate_producer_params ) }
it 'configures desginate produce with non default parameters' do
is_expected.to contain_designate_config("service:producer/workers").with(:value => '3')
is_expected.to contain_designate_config("service:producer/threads").with(:value => '3000')
is_expected.to contain_designate_config("service:producer/enabled_tasks").with(:value => ['domain_purge','periodic_secondary_refresh'])
is_expected.to contain_designate_config("coordination/backend_url").with(:value => 'redis://10.0.0.1:1234')
is_expected.to contain_designate_config("service:producer/workers").with_value('3')
is_expected.to contain_designate_config("service:producer/threads").with_value('3000')
is_expected.to contain_designate_config("service:producer/enabled_tasks").with_value('domain_purge,periodic_secondary_refresh')
is_expected.to contain_designate_config("coordination/backend_url").with_value('redis://10.0.0.1:1234')
end
end
end