openstack
/
puppet-ec2api
Code Issues Proposed changes

Merge "Do not test detail of keystone::resource::service_identity"

This commit is contained in:
Zuul 2021-10-02 11:38:47 +00:00 committed by Gerrit Code Review
parent 04a8943478 ed337c9942
commit f74f33e5d7
1 changed files with 71 additions and 85 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

112
spec/classes/ec2api_keystone_auth_spec.rb
View File

@ -1,28 +1,17 @@
#
# Unit tests for ec2api::keystone::auth
#
require 'spec_helper' require 'spec_helper'
describe 'ec2api::keystone::auth' do describe 'ec2api::keystone::auth' do
on_supported_os(supported_os: OSDefaults.get_supported_os).each do |os,facts| shared_examples_for 'ec2api::keystone::auth' do
context "on #{os}" do context 'with default class parameters' do
let :params do
let(:facts) { facts } { :password => 'ec2api_password' }
describe 'with default parameters' do
let(:params) do
{
password: 'my_password',
}
end end
it { is_expected.to compile.with_all_deps } it { is_expected.to contain_keystone__resource__service_identity('ec2api').with(
it { is_expected.to contain_class('ec2api::keystone::auth') }
it { is_expected.to contain_class('ec2api::params') }
it { is_expected.to contain_class('ec2api::deps') }
it do
parameters = {
:configure_user => true, :configure_user => true,
:configure_user_role => true, :configure_user_role => true,
:configure_endpoint => true, :configure_endpoint => true,
@ -31,64 +20,61 @@ describe 'ec2api::keystone::auth' do
:service_description => 'The EC2 API Service', :service_description => 'The EC2 API Service',
:region => 'RegionOne', :region => 'RegionOne',
:auth_name => 'ec2api', :auth_name => 'ec2api',
:password => 'my_password', :password => 'ec2api_password',
:email => 'ec2api@localhost', :email => 'ec2api@localhost',
:tenant => 'services', :tenant => 'services',
:public_url => 'http://127.0.0.1:8788', :public_url => 'http://127.0.0.1:8788',
:internal_url => 'http://127.0.0.1:8788', :internal_url => 'http://127.0.0.1:8788',
:admin_url => 'http://127.0.0.1:8788', :admin_url => 'http://127.0.0.1:8788',
} ) }
is_expected.to contain_keystone__resource__service_identity('ec2api').with(parameters)
end
end end
describe 'with custom parameters' do context 'when overriding parameters' do
let(:params) do let :params do
{ { :password => 'ec2api_password',
password: 'my_password', :auth_name => 'alt_ec2api',
auth_name: 'me', :email => 'alt_ec2api@alt_localhost',
email: 'me@localhost', :tenant => 'alt_service',
tenant: 'my_tenant', :configure_endpoint => false,
configure_endpoint: false, :configure_user => false,
configure_user: false, :configure_user_role => false,
configure_user_role: false, :service_description => 'Alternative The EC2 API Service',
service_name: 'my_service', :service_name => 'alt_service',
service_description: 'The service', :service_type => 'alt_ec2api',
service_type: 'my_type', :region => 'RegionTwo',
region: 'my_region', :public_url => 'https://10.10.10.10:80',
public_url: 'http://192.168.0.1:8788', :internal_url => 'http://10.10.10.11:81',
internal_url: 'http://192.168.0.1:8788', :admin_url => 'http://10.10.10.12:81' }
admin_url: 'http://192.168.0.1:8788',
}
end end
it { is_expected.to compile.with_all_deps } it { is_expected.to contain_keystone__resource__service_identity('ec2api').with(
it { is_expected.to contain_class('ec2api::keystone::auth') }
it { is_expected.to contain_class('ec2api::params') }
it do
parameters = {
:configure_user => false, :configure_user => false,
:configure_user_role => false, :configure_user_role => false,
:configure_endpoint => false, :configure_endpoint => false,
:service_name => 'my_service', :service_name => 'alt_service',
:service_type => 'my_type', :service_type => 'alt_ec2api',
:service_description => 'The service', :service_description => 'Alternative The EC2 API Service',
:region => 'my_region', :region => 'RegionTwo',
:auth_name => 'me', :auth_name => 'alt_ec2api',
:password => 'my_password', :password => 'ec2api_password',
:email => 'me@localhost', :email => 'alt_ec2api@alt_localhost',
:tenant => 'my_tenant', :tenant => 'alt_service',
:public_url => 'http://192.168.0.1:8788', :public_url => 'https://10.10.10.10:80',
:internal_url => 'http://192.168.0.1:8788', :internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://192.168.0.1:8788', :admin_url => 'http://10.10.10.12:81',
} ) }
is_expected.to contain_keystone__resource__service_identity('ec2api').with(parameters)
end end
end end
on_supported_os({
:supported_os => OSDefaults.get_supported_os
}).each do |os,facts|
context "on #{os}" do
let (:facts) do
facts.merge!(OSDefaults.get_facts())
end
it_behaves_like 'ec2api::keystone::auth'
end end
end end
end end