openstack/puppet-glance
Code Issues Proposed changes

Use static name for package resource

Browse Source 
... instead of using the actual package name. This helps users to
identify the resource name more easily.

Change-Id: Icc6a27685f3b3747b4e0562eb8066aa3cce5516c
This commit is contained in:
Takashi Kajinami
2023-03-11 12:28:24 +09:00
parent 951936517b
commit 2f23343e4f
5 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/api.pp
View File

@@ -348,7 +348,7 @@ class glance::api(
} }
if ( $glance::params::api_package_name != undef ) { if ( $glance::params::api_package_name != undef ) {
package { $::glance::params::api_package_name : package { 'glance-api':
ensure => $package_ensure, ensure => $package_ensure,
name => $::glance::params::api_package_name, name => $::glance::params::api_package_name,
tag => ['openstack', 'glance-package'], tag => ['openstack', 'glance-package'],

2
manifests/init.pp
View File

@@ -17,7 +17,7 @@ class glance(
include glance::params include glance::params
if ( $glance::params::package_name != undef ) { if ( $glance::params::package_name != undef ) {
package { $::glance::params::package_name : package { 'glance' :
ensure => $package_ensure, ensure => $package_ensure,
name => $::glance::params::package_name, name => $::glance::params::package_name,
tag => ['openstack', 'glance-package'], tag => ['openstack', 'glance-package'],

1
spec/classes/glance_api_spec.rb
View File

@@ -534,6 +534,7 @@ describe 'glance::api' do
end end
it { is_expected.to contain_package('glance-api').with( it { is_expected.to contain_package('glance-api').with(
:ensure => package_ensure, :ensure => package_ensure,
:name => 'glance-api',
:tag => ['openstack', 'glance-package'] :tag => ['openstack', 'glance-package']
)} )}
end end

3
spec/classes/glance_init_spec.rb
View File

@@ -16,8 +16,9 @@ describe 'glance' do
let(:params) do let(:params) do
{ :package_ensure => package_ensure } { :package_ensure => package_ensure }
end end
it { is_expected.to contain_package('openstack-glance').with( it { is_expected.to contain_package('glance').with(
:ensure => package_ensure, :ensure => package_ensure,
:name => 'openstack-glance',
:tag => ['openstack', 'glance-package'] :tag => ['openstack', 'glance-package']
)} )}
end end

6
spec/classes/glance_spec.rb
View File

@@ -23,8 +23,10 @@ describe 'glance' do
shared_examples_for 'glance RedHat' do shared_examples_for 'glance RedHat' do
let(:params) { default_params } let(:params) { default_params }
it { is_expected.to contain_package('openstack-glance').with( it { is_expected.to contain_package('glance').with(
:tag => ['openstack', 'glance-package'], :ensure => 'present',
:name => 'openstack-glance',
:tag => ['openstack', 'glance-package'],
)} )}
end end